perf: Optimize TTS pool using deadpool (Issue #32)#43
Open
NTLx wants to merge 2 commits intosecond-state:mainfrom
Open
perf: Optimize TTS pool using deadpool (Issue #32)#43NTLx wants to merge 2 commits intosecond-state:mainfrom
NTLx wants to merge 2 commits intosecond-state:mainfrom
Conversation
Collaborator
|
When is an idle object destroyed? |
Author
|
In the previous implementation, idle objects were not automatically destroyed because the pool was missing timeout configurations. I have just updated the PR to include deadpool's Timeouts (wait and create timeouts set to 30 seconds). This ensures the pool doesn't hang indefinitely and provides a foundation for resource management. For active reaping of idle objects, we can further implement a periodic cleanup task or leverage deadpool's post-processing if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a proper object pool for TTS sessions using
deadpool, addressing Issue #32.This contribution is part of the OceanBase AI Coding Event.
🚀 Improvements
deadpool, a battle-tested object pooling library for Rust.deadpool's lifecycle management.🛠 Implementation
deadpool = "0.10"toCargo.toml.TTSManagerstruct which implementsdeadpool::managed::Manager.TTSSessionPoolto wrapdeadpool::managed::Pool<TTSManager>.run_loopto lease sessions from the pool usingpool.get().await.✅ AI Contribution Details
tts.rsas a candidate for optimization.deadpoolpattern (Manager + Recycle).