Add date filters and refactor quality metrics#111
Merged
ackermannW merged 1 commit intosecomind:mainfrom Feb 19, 2026
Merged
Conversation
AmerMesanovic
force-pushed
the
filters
branch
from
55360ac to
3ecb559
Compare
ackermannW
requested changes
Feb 18, 2026
| const [dataFetching, setDataFetching] = useState(false); | ||
| const [imageIds, setImageIds] = useState<string[]>([]); | ||
| const [allData, setAllData] = useState<any[]>([]); | ||
| const [imageIds, setImageIds] = useState<Record<string, ImageData>>({}); |
Collaborator
There was a problem hiding this comment.
This is a leftover from previous iteration of this PR. We should rename this variable from imageIds to imagesRecords or something similar.
AmerMesanovic
force-pushed
the
filters
branch
5 times, most recently
from
559c73b to
c36bb5f
Compare
Emina-M
requested changes
Feb 18, 2026
Comment on lines
+50
to
+55
| const response = await this.axiosInstance.get( | ||
| `v1/${realm}/devices/${deviceId}/interfaces/com.oobe.quality.Inspection`, | ||
| { params }, | ||
| ); | ||
|
|
||
| return response.data?.data ?? {}; |
Collaborator
There was a problem hiding this comment.
Add params without changing data handling logic.
| ): Promise<Record<string, ImageData>> { | ||
| const { realm } = this.config; | ||
|
|
||
| const params: any = {}; |
Collaborator
There was a problem hiding this comment.
Suggested change
| const params: any = {}; | |
| const params: Record<string, string> = {}; |
| import { isRangePreset, presetToDateRange } from "./components/RangeSelect"; | ||
| import StatsOverview from "./components/StatsOverview"; | ||
| import IndustrialBarChart from "./components/IndustrialBarChart"; | ||
| import { ImageData as AstarteImageData } from "types"; |
Collaborator
There was a problem hiding this comment.
Name ImageData does not clash with anything, we don't need an alias for it. Same goes for its import in other files.
| const [dataFetching, setDataFetching] = useState(false); | ||
| const [imagesData, setImagesData] = useState<Record<string, ImageData>>({}); | ||
| const [allData, setAllData] = useState<AstarteImageData[]>([]); | ||
| const [imagesRecords, setImageRecord] = useState< |
Collaborator
There was a problem hiding this comment.
Revert renaming this state variable.
Comment on lines
+42
to
+60
| try { | ||
| const imageRecords = await astarteClient.getImagesData( | ||
| deviceId, | ||
| since, | ||
| to, | ||
| ); | ||
| setImageRecord(imageRecords); | ||
| const keys = Object.keys(imageRecords); | ||
| if (keys.length === 0) { | ||
| setAllData([]); | ||
| return; | ||
| } | ||
| const formattedData = Object.values(imageRecords); | ||
| setAllData(formattedData); | ||
| } catch (e: any) { | ||
| setError(e.message || "Error fetching data"); | ||
| } finally { | ||
| setDataFetching(false); | ||
| } |
Collaborator
There was a problem hiding this comment.
I like the idea of extracting fetching data to its own function outside of useEffect, but you should build your code on top of existing code for calling astarteClient.getImagesData().
| <Container | ||
| fluid | ||
| className="p-4" | ||
| style={{ backgroundColor: "#fbfbfc", minHeight: "100vh" }} |
Collaborator
There was a problem hiding this comment.
Specifying backgroundColor is unnecessary.
Emina-M
requested changes
Feb 18, 2026
| "@formatjs/intl": "^4.1.2", | ||
| "@fortawesome/fontawesome-svg-core": "^6.6.0", | ||
| "@fortawesome/free-solid-svg-icons": "^6.6.0", | ||
| "@fortawesome/react-fontawesome": "^0.2.2", |
Collaborator
There was a problem hiding this comment.
Use a newer version of this package because this one gives a deprecated warning.
AmerMesanovic
force-pushed
the
filters
branch
5 times, most recently
from
c4899ab to
905df54
Compare
Integrated date range presets (Day, Week, Month, Year).Refactored quality statistics into a standalone StatsOverview component Signed-off-by: AmerMesanovic <amer.mesanovic@secomind.com>
AmerMesanovic
force-pushed
the
filters
branch
from
905df54 to
c63ac82
Compare
ackermannW
approved these changes
Feb 19, 2026
This was referenced Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated date range presets (Day, Week, Month, Year).Refactored quality statistics into a standalone StatsOverview component
Screen:
Closes #81