Force-derive thumbnail filename via timestamp#53
Merged
Conversation
arrdalan
requested changes
Apr 11, 2026
Collaborator
arrdalan
left a comment
arrdalan
left a comment
There was a problem hiding this comment.
It seems like we won't need the filename field in ThumbnailMetaInfo anymore. If this is the case, please go ahead and remove it.
jkaczman
changed the title
Collaborator
Author
Thanks! Fixed. Please let me know if you see anything else. if it looks good, please squash this one. |
arrdalan
requested changes
Apr 19, 2026
Collaborator
arrdalan
left a comment
arrdalan
left a comment
There was a problem hiding this comment.
Tested this with RPi and Android. Thumbnails now don't show up in the app at all. Most likely, there's something wrong with the thumbnail filenames. It needs more debugging.
Collaborator
|
I just realized that I didn't update the app_native code in the app, which this PR seems to modify. I'll test again shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stops trusting sender-controlled thumbnail filenames. Instead, the app derives thumbnail filenames from the timestamp using a fixed format.