Skip to content

Conversation

@gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Feb 8, 2026

  • minor bug fix with NCACN_NP HOST being not set
  • pretty big padding bug with the trailing gap of deported conformant arrays embedded in structures. I read the documentation too quickly but man is this complicated...
  • move msrpce tests + add new ones
  • some string fields had their \x00 eaten by the bad padding :(
  • add scapy-rpc UTS config

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.86%. Comparing base (548c7eb) to head (81a689e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/dcerpc.py 87.50% 2 Missing ⚠️
scapy/tools/UTscapy.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4910      +/-   ##
==========================================
+ Coverage   80.84%   80.86%   +0.01%     
==========================================
  Files         369      369              
  Lines       90984    91024      +40     
==========================================
+ Hits        73560    73606      +46     
+ Misses      17424    17418       -6     
Files with missing lines Coverage Δ
scapy/layers/msrpce/msdcom.py 36.32% <ø> (ø)
scapy/layers/msrpce/raw/ept.py 100.00% <100.00%> (ø)
scapy/layers/msrpce/raw/ms_dcom.py 100.00% <100.00%> (ø)
scapy/layers/msrpce/raw/ms_nrpc.py 100.00% <ø> (ø)
scapy/layers/msrpce/rpcclient.py 57.34% <100.00%> (+0.14%) ⬆️
scapy/tools/UTscapy.py 65.11% <75.00%> (+0.05%) ⬆️
scapy/layers/dcerpc.py 90.02% <87.50%> (-0.08%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 force-pushed the dcerpc-tests branch 2 times, most recently from d6c8ce7 to 1605d17 Compare February 9, 2026 02:58
@gpotter2 gpotter2 merged commit fec8617 into secdev:master Feb 9, 2026
23 of 24 checks passed
@gpotter2 gpotter2 deleted the dcerpc-tests branch February 9, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant