BUG: use notification structs from include/seccomp.h #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to duplicate struct definitions unless absolutely necessary. Signed-off-by: Paul Moore <paul@paul-moore.com>
drakenclimber
approved these changes
Aug 21, 2025
Member
drakenclimber
left a comment
drakenclimber
left a comment
There was a problem hiding this comment.
LGTM. I compared our current list of defines with what is in the kernel's seccomp.h, and I think you've defined the bare minimum in the case where those structs/#defines don't exist.
Acked-by: Tom Hromatka <tom.hromatka@oracle.com>
Member
Author
|
Merged via dee17d0, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to duplicate struct definitions unless absolutely necessary, so rely on seccomp.h definitions inside system.h. A very minor thing, but we should fix this at some point.