-
Notifications
You must be signed in to change notification settings - Fork 188
RFE: add License variable to pkg-config file #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pcmoore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our license is "LGPL-2.1" not "LGPL-2.1-or-later", but otherwise I think this is okay.
libseccomp.pc.in
Outdated
| Version: @PACKAGE_VERSION@ | ||
| Cflags: -I${includedir} | ||
| Libs: -L${libdir} -lseccomp | ||
| License: LGPL-2.1-or-later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libseccomp is released under a "LGPL v2.1 only" license as opposed to a "LGPL v2.1 or later" license according to the LICENSE and the presence of an explicit version number in the source files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libseccomp is released under a "LGPL v2.1 only" license as opposed to a "LGPL v2.1 or later" license according to the LICENSE and the presence of an explicit version number in the source files.
My bad. Thanks for your review. I will fix it.
The pkg-config file has License variable that allows you to set the license for the software. This sets 'LGPL-2.1-only' as defined in SPDX to License. Ref: https://github.com/pkgconf/pkgconf/blob/master/man/pc.5#L116 Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
8164f86 to
ce4eead
Compare
drakenclimber
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Acked-by: Tom Hromatka <tom.hromatka@oracle.com>
|
Merged via 5491c4b, thanks! |
The pkg-config file has License variable that allows you to set the license for the software.
This sets 'LGPL-2.1-or-later' as defined in SPDX to License.
Ref: https://github.com/pkgconf/pkgconf/blob/master/man/pc.5#L116