Skip to content

Conversation

@iwamatsu
Copy link
Contributor

The pkg-config file has License variable that allows you to set the license for the software.
This sets 'LGPL-2.1-or-later' as defined in SPDX to License.

Ref: https://github.com/pkgconf/pkgconf/blob/master/man/pc.5#L116

@pcmoore pcmoore changed the title Add License variable to pkg-config file RFE: add License variable to pkg-config file May 1, 2025
@pcmoore pcmoore added this to the v2.7.0 milestone May 1, 2025
@coveralls
Copy link

coveralls commented May 1, 2025

Coverage Status

coverage: 89.046%. remained the same
when pulling ce4eead on iwamatsu:update-pkg-config
into c375ae5 on seccomp:main.

Copy link
Member

@pcmoore pcmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our license is "LGPL-2.1" not "LGPL-2.1-or-later", but otherwise I think this is okay.

libseccomp.pc.in Outdated
Version: @PACKAGE_VERSION@
Cflags: -I${includedir}
Libs: -L${libdir} -lseccomp
License: LGPL-2.1-or-later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libseccomp is released under a "LGPL v2.1 only" license as opposed to a "LGPL v2.1 or later" license according to the LICENSE and the presence of an explicit version number in the source files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcmoore

libseccomp is released under a "LGPL v2.1 only" license as opposed to a "LGPL v2.1 or later" license according to the LICENSE and the presence of an explicit version number in the source files.

My bad. Thanks for your review. I will fix it.

@pcmoore pcmoore requested a review from drakenclimber May 1, 2025 15:18
The pkg-config file has License variable that allows you to set the license for
the software. This sets 'LGPL-2.1-only' as defined in SPDX to License.

Ref: https://github.com/pkgconf/pkgconf/blob/master/man/pc.5#L116
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
@iwamatsu iwamatsu force-pushed the update-pkg-config branch from 8164f86 to ce4eead Compare May 1, 2025 20:49
Copy link
Member

@drakenclimber drakenclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Acked-by: Tom Hromatka <tom.hromatka@oracle.com>

@pcmoore
Copy link
Member

pcmoore commented May 9, 2025

Merged via 5491c4b, thanks!

@pcmoore pcmoore closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants