Coverage-xml cannot contain pcov and xdebug at the same time#1132
Closed
staabm wants to merge 1 commit intosebastianbergmann:mainfrom
Closed
Coverage-xml cannot contain pcov and xdebug at the same time#1132staabm wants to merge 1 commit intosebastianbergmann:mainfrom
staabm wants to merge 1 commit intosebastianbergmann:mainfrom
Conversation
attribute name needs to be unique
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
=========================================
Coverage 88.42% 88.42%
Complexity 1390 1390
=========================================
Files 105 105
Lines 4700 4700
=========================================
Hits 4156 4156
Misses 544 544 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can confirm that this works and generates valid XML. |
Owner
|
Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attribute name needs to be unique
closes #1131
this regressed in 5b74f62 which previously used DOM to de-duplicate the attribute name automatically because it just overwrote the previous value