Conversation
Member
Author
|
@havok2063 I think this is at the stage of what we can do without manually having to go over each column with missing descriptions. There are many v1 tables that don't have documentation but will after DocuCharm. We can merge now and update those later or wait until we have them. Let me know if there are tables with missing columns that are important and I can add those now. |
havok2063
approved these changes
Jan 16, 2026
Collaborator
havok2063
left a comment
There was a problem hiding this comment.
This looks good to me. I think I mostly want the parent catalog tables so I can add descriptions in Zora to those columns in the Sources tab under "Parent Catalogs".
I'm ok merging now and doing another pass after DocuCharm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first pass at generating complete schema metadata for
catalogdb. Most tables and columns are now there, copied fromminidb_docsbut a number of them are still missing. These roughly fall in two categories:catalogdbbut that were unpacked into multiple columns in minidb and the column names don't match. For these we do have descriptions in minidb but they need to be manually updated.Another caveat is that the
display_nameis just the same ascolumn_name. It would take a lot of effort to manually add a display name for all columns, so I think we should only do it for special cases.Here's the list of columns/tables that still need fixing:
Fixes #263