Merged
Conversation
Contributor
henderiw
commented
Feb 18, 2026
henderiw
commented
- Align with latest apiServer of Kubernetes and controller runtime
henderiw
added
the
safe to test
henderiw
removed
safe to test
Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com>
Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com>
Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com>
Co-authored-by: Alexander North <alexandernorth@users.noreply.github.com>
…fig was not the actual config we transacted
…fig was not the actual config we transacted
alexandernorth
approved these changes
Apr 13, 2026
Comment on lines
+391
to
+396
| if newConfigCond.Equal(curConfigCond) && | ||
| newOverallCond.Equal(curOverallCond) && | ||
| (recoverable || | ||
| (current.Status.DeviationGeneration != nil && | ||
| *current.Status.DeviationGeneration == 0)) { | ||
| return nil |
Contributor
There was a problem hiding this comment.
maybe this expression could be simplified? or explained? Otherwise LGTM
steiler
reviewed
Apr 14, 2026
Comment on lines
+83
to
+84
| - name: KUBE_FEATURE_WatchListClient | ||
| value: "false" |
steiler
reviewed
Apr 14, 2026
Comment on lines
+81
to
+82
| - name: KUBE_FEATURE_WatchListClient | ||
| value: "false" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.