(improvement) remove protocol_version where possible #642
+405
−490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In most of the cases, it is simply not needed. For the very few cases it is, kept it. I think it simplifies the code. Signed-off-by: Yaniv Kaul <yaniv.kaul@scylladb.com>
Author
|
(Mostly done with AI, so blame it if it doesn't work) |
The Cython implementation in row_parser.pyx expects recv_results_rows() to take protocol_version as a parameter. Updated both the call site and method signature in protocol.py to match. This fixes the "recv_results_rows() takes exactly 6 positional arguments (5 given)" error that was causing authentication and cluster test failures.
OrderedMapSerializedKey now takes a single cass_type_instance argument instead of (cass_type, protocol_version). Updated the Cython deserializer to instantiate the key_type with protocol_version before passing it. This fixes the "map<varchar, varchar>: __init__() takes exactly 2 positional arguments (3 given)" error.
Changed desc.protocol_version to deserializer.protocol_version since protocol_version was removed from ParseDesc as part of the refactoring. The protocol_version is now stored in the Deserializer instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most of the cases, it is simply not needed. For the very few cases it is, kept it. I think it simplifies the code.
CoPi did most of the work, I've looked after the horrors.
Pre-review checklist
./docs/source/.Fixes:annotations to PR description.