Skip to content

Conversation

@dkropachev
Copy link
Collaborator

Node pools should be stable, if cc fails to connect it is not good enough reason to neither to kill it nor to mark node down.
Doing that opens up cases when control connection marks nodes down and kills pools due to the short leaved network glitch.

Fixes: #622

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

Node pools should be stable, if cc fails to connect it is not good
enough reason to neither to kill it nor to mark node down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control connection reconnect can mark nodes down

1 participant