Skip to content

Conversation

@dgarcia360
Copy link
Collaborator

@dgarcia360 dgarcia360 commented Nov 17, 2025

Related scylladb/sphinx-scylladb-theme#1516

image

How to test

  1. Build the docs.
  2. Open the API reference.
  3. Review the new UI at http://127.0.0.1:5500/api/

@dgarcia360 dgarcia360 marked this pull request as draft November 17, 2025 09:14
@dgarcia360 dgarcia360 marked this pull request as ready for review November 21, 2025 17:37
@dgarcia360
Copy link
Collaborator Author

cc/ @annastuchlik

@Lorak-mmk
Copy link

I rendered docs before and after this PR.
Before:
image
After:
image

The only difference I see is that the short descriptions of docs chapters were removed - which is imo a regression.

The unreadable style of docs was not fixed. See this:
image

This is basically a wall of test. Compare this with pytest docs (which is also made with Sphinx!).
image

  • Class / method / field names are clearly visible in red, so you always know which section some text belongs to.
  • Indentations clearly show which class a method belongs to, and also which method given doc text belongs to.

@dgarcia360
Copy link
Collaborator Author

@Lorak-mmk commited uv.lock in https://github.com/scylladb/python-driver/pull/593/commits/de80de7770f1b78af6f5f61b1651ef27ce8ecaecusing latest theme version.

Please try again.

Copy link

@Lorak-mmk Lorak-mmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is current state:
image

It's much better, a clear improvement over what we had until now!

If I may have some suggestions (which are possibly out of scope for this PR, idk):

  • I love that list on the right is now collapsible. It would be great if it was possible to expand / collapse given section without jumping to it, by clicking on the small arrow in the section.
  • To add to that, maybe consider "collapse all" / "expand all" button?
  • Color schema is all black / white / gray. Docs for devs should be easy to glance at after many hours of work when brain and eyes are tired. Most devs are also used to colorful syntax highlighting in their IDEs. Please consider changing the colors for things like class names, method names etc.

@dgarcia360
Copy link
Collaborator Author

Thanks @Lorak-mmk for the feedback! Moved the improvements here to take them into account in a future version of the theme.

@dkropachev dkropachev merged commit 067a85c into scylladb:master Nov 27, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants