Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 92.11% 92.11%
=======================================
Files 48 48
Lines 7429 7429
=======================================
Hits 6843 6843
Misses 586 586 🚀 New features to boost your workflow:
|
Member
|
Thanks @aeisenbarth for starting this work.
Now the conflicts with dask are resolved thanks to @melonora's PR. Regarding this PR, I labeled as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work-in-progress for testing performance of
geopandascompared todask-geopandas.I used the
asvframework to add benchmarks for geopandas nearest and query.Unfortunately, dask-geopandas doesn't implement these functions yet. However, this code can be used as a starting point to continue performance tests.
Note also that the latest version of dask-geopandas is only compatible with newer dask dependencies.
Refers to #233, #739