Fix render_points crash when coloring by spatial coord (x/y)#671
Merged
Conversation
Coloring by a coordinate column (x or y) caused a duplicate column append into the dask projection list, raising on .compute(). Skip the append when the color column is already part of the projected coords. Closes #613
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
=======================================
Coverage 77.63% 77.63%
=======================================
Files 11 11
Lines 3612 3613 +1
Branches 850 851 +1
=======================================
+ Hits 2804 2805 +1
Misses 485 485
Partials 323 323
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render_points(color="x")andcolor="y"crashed because the coord column was appended to the dask projection list a second time, leading to a duplicate-column failure on.compute().coords.Closes #613