Normalization factors and DESeqDataSetFromTximport equivalent#412
Draft
maltekuehl wants to merge 4 commits intoscverse:mainfrom
Draft
Normalization factors and DESeqDataSetFromTximport equivalent#412maltekuehl wants to merge 4 commits intoscverse:mainfrom
maltekuehl wants to merge 4 commits intoscverse:mainfrom
Conversation
Collaborator
|
Hi @maltekuehl, sorry I haven't had the time to review your PR yet. To answer your last remark: I'm all for switching to uv for package management. I don't see much of an issue in dropping support for python 3.10 starting from v0.5.3 as many packages (e.g., numpy) have also stopped supporting it in their latest releases. Please go ahead if you wish to handle those changes! I'd just suggest you make them in a separate PR. I'll try to have a look at this PR ASAP |
[pre-commit.ci] pre-commit autoupdate (scverse#415)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305 and closes #359. Adds support for normalization factors based on length provided by
pytximport. Very much still a draft.Open issues:
Aside: Tests pass locally but fail due to an older AnnData version on Python 3.10 here. Would you be open for this PR to also include an update of the pre-commit, GitHub Actions, full move to uv/hatch/ruff like other scverse ecosystem packages and targeting Python 3.11 - 3.13?
CC @BorisMuzellec