-
Notifications
You must be signed in to change notification settings - Fork 99
Increase height of annotation buttons to match Scribe key (#535) #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase height of annotation buttons to match Scribe key (#535) #536
Conversation
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
The failed check is not related to the changes i guess. @andrewtavis |
|
Thanks for the PR, @bhanu-dev82! We'll take a look at the tests and hopefully will figure it out :) |
|
Looks like we just needed to rerun the tests :) |
|
Hey @bhanu-dev82 Could you check whether the changes are visible on a Pixel emulator. It is currently not being visible for me in a Pixel emulator 9A to be specific. |
yes, the changes are visible. In German keyboard type buch then space, you will see N in the green container equal in height to scribe key |
angrezichatterbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @bhanu-dev82. The changes looks good to me. It's all good to merge. @andrewtavis
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked earlier and it was working for me as well 😊
praise: Thanks for the quick work here on a major improvement to consistency in the UI, @bhanu-dev82! 🚀
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request addresses a UI inconsistency where the keyboard annotation buttons were not the same height as the Scribe key.
Testing:
Verified that when using the German keyboard and typing a noun (e.g., "Buch"), the displayed annotation (e.g., the green "N") is now the same height as the Scribe key.
Screenshots:
Screenshots
Fix the Annotation to match the Scribe Key
Now the Command Buttons are also perfectly consistent with Scribe key