Skip to content

Conversation

@bhanu-dev82
Copy link
Collaborator

Contributor checklist


Description

This pull request addresses a UI inconsistency where the keyboard annotation buttons were not the same height as the Scribe key.

  • Added a new dimension resource command_button_height (37dp) in dimens.xml.
    
  • Updated input_method_view.xml to replace the hardcoded height of the Scribe key (scribe_key_options) with this new dimension.
    
  • Increased the height of the annotation buttons (translate_btn, conjugate_btn, and plural_btn) to @dimen/command_button_height so they perfectly match the Scribe key.
    

Testing:

Verified that when using the German keyboard and typing a noun (e.g., "Buch"), the displayed annotation (e.g., the green "N") is now the same height as the Scribe key.

Screenshots:

Screenshots

Fix the Annotation to match the Scribe Key

Now the Command Buttons are also perfectly consistent with Scribe key

### Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

github-actions bot commented Jan 18, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@bhanu-dev82
Copy link
Collaborator Author

bhanu-dev82 commented Jan 18, 2026

The failed check is not related to the changes i guess. @andrewtavis

@andrewtavis
Copy link
Member

Thanks for the PR, @bhanu-dev82! We'll take a look at the tests and hopefully will figure it out :)

@andrewtavis
Copy link
Member

Looks like we just needed to rerun the tests :)

@angrezichatterbox
Copy link
Member

Hey @bhanu-dev82

Could you check whether the changes are visible on a Pixel emulator. It is currently not being visible for me in a Pixel emulator 9A to be specific.

@bhanu-dev82
Copy link
Collaborator Author

Hey @bhanu-dev82

Could you check whether the changes are visible on a Pixel emulator. It is currently not being visible for me in a Pixel emulator 9A to be specific.

yes, the changes are visible. In German keyboard type buch then space, you will see N in the green container equal in height to scribe key

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bhanu-dev82. The changes looks good to me. It's all good to merge. @andrewtavis

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked earlier and it was working for me as well 😊

praise: Thanks for the quick work here on a major improvement to consistency in the UI, @bhanu-dev82! 🚀

@andrewtavis andrewtavis merged commit 18220f6 into scribe-org:main Jan 18, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase height of annotation buttons within keyboard UI

3 participants