Tokenizer fixes and span_tokenize method#20
Open
chekunkov wants to merge 267 commits intoscrapinghub:masterfrom
Open
Tokenizer fixes and span_tokenize method#20chekunkov wants to merge 267 commits intoscrapinghub:masterfrom
chekunkov wants to merge 267 commits intoscrapinghub:masterfrom
Conversation
…names_filename automatically
…less memory efficient)
Dropping it gives a nice speedup because computations are now in Cython.
…simplify code and make it faster. If needed, it can be implemented as a global feature.
…use code. span_tokenize method.
Conflicts: webstruct/text_tokenizers.py
Member
|
@chekunkov do you by chance recall why wasn't this PR merged? |
Contributor
Author
|
@kmike nope, have no idea why. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokenizer from #15 had issues like not splitting a dot at the end of a sentence as a separate token
Now this issue should be fixed.
Also I've refactored code and added span_tokenize method (@kmike I remember you said it would be nice to have this method)
Performance wasn't hurt