Skip to content

Update Nightly build images to Nightly builds#225

Merged
phracek merged 1 commit intosclorg:masterfrom
phracek:update_tmt-images
Mar 31, 2026
Merged

Update Nightly build images to Nightly builds#225
phracek merged 1 commit intosclorg:masterfrom
phracek:update_tmt-images

Conversation

@phracek
Copy link
Copy Markdown
Member

@phracek phracek commented Mar 31, 2026

Summary by CodeRabbit

  • Chores
    • Updated upstream daily tests image version to 0.8.10
    • Updated RHEL nightly test target versions: RHEL 9 to 9.8.0 and RHEL 10 to 10.2

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

📝 Walkthrough

Walkthrough

This PR updates version references across build and test configuration files. The upstream daily tests image version is bumped from 0.8.9 to 0.8.10 in the workflow, Dockerfile, and Makefile. Additionally, nightly test COMPOSE targets are updated to newer RHEL release versions (9.6.0 → 9.8.0 and 10 → 10.2).

Changes

Cohort / File(s) Summary
Image and Release Version Updates
.github/workflows/build-and-push.yml, Dockerfile.daily-tests, Makefile
Updated upstream daily tests image tag and release version from 0.8.9 to 0.8.10 across workflow, Dockerfile environment variable, and build target.
Nightly Test COMPOSE Targets
run_nightly_tests.sh
Updated get_compose() function to use newer RHEL nightly builds: rhel9 changed from RHEL-9.6.0-Nightly to RHEL-9.8.0-Nightly; rhel10 changed from RHEL-10-Nightly to RHEL-10.2-Nightly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Hop, hop! New versions bloom,
From 0.8.9 to 0.8.10 we zoom,
RHEL upgrades, so fresh and bright,
Nightly tests now running right!
Carrots don't need to wait, they're set—
The best CI pipeline yet! 🥕✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is vague and generic—'Update Nightly build images to Nightly builds' uses circular/tautological phrasing that doesn't clearly convey what specific versions or changes are being made across multiple files. Consider a more specific title that indicates the actual version updates, such as 'Update upstream-daily-tests image and RHEL nightly compose versions' or similar.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.50%. Comparing base (e16f175) to head (2992b61).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   35.50%   35.50%           
=======================================
  Files           7        7           
  Lines        1011     1011           
=======================================
  Hits          359      359           
  Misses        652      652           
Flag Coverage Δ
daily-tests-unit 26.23% <ø> (ø)
ocp-stream-generator-unit 84.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile.daily-tests (1)

5-5: Centralize the upstream image version to avoid future drift.

RELEASE_UPSTREAM at Line 5 is manually synchronized with Makefile (Line 10) and workflow tag (Line 22). Consider using one source of truth (e.g., CI env var/build arg) to prevent mismatch in future bumps.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile.daily-tests` at line 5, The Dockerfile currently hardcodes
RELEASE_UPSTREAM which diverges from the Makefile and workflow tag; replace the
literal with a build-time ARG or environment variable so a single source of
truth is used: add ARG RELEASE_UPSTREAM (or use an existing CI env var) in the
Dockerfile and reference that ARG where RELEASE_UPSTREAM is used, then update
the Makefile target and CI workflow to pass the same build-arg/env (e.g., docker
build --build-arg RELEASE_UPSTREAM=$RELEASE_UPSTREAM or export RELEASE_UPSTREAM
in CI) so the Dockerfile, Makefile, and workflow consume the same variable
rather than duplicating the version string.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Dockerfile.daily-tests`:
- Line 5: The Dockerfile currently hardcodes RELEASE_UPSTREAM which diverges
from the Makefile and workflow tag; replace the literal with a build-time ARG or
environment variable so a single source of truth is used: add ARG
RELEASE_UPSTREAM (or use an existing CI env var) in the Dockerfile and reference
that ARG where RELEASE_UPSTREAM is used, then update the Makefile target and CI
workflow to pass the same build-arg/env (e.g., docker build --build-arg
RELEASE_UPSTREAM=$RELEASE_UPSTREAM or export RELEASE_UPSTREAM in CI) so the
Dockerfile, Makefile, and workflow consume the same variable rather than
duplicating the version string.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f64c2b3a-4ea2-4ac7-8d2e-f58f3b67f4c9

📥 Commits

Reviewing files that changed from the base of the PR and between e16f175 and 2992b61.

📒 Files selected for processing (4)
  • .github/workflows/build-and-push.yml
  • Dockerfile.daily-tests
  • Makefile
  • run_nightly_tests.sh

@phracek phracek merged commit 4f80e99 into sclorg:master Mar 31, 2026
11 checks passed
This was referenced Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant