Update Nightly build images to Nightly builds#225
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
📝 WalkthroughWalkthroughThis PR updates version references across build and test configuration files. The upstream daily tests image version is bumped from 0.8.9 to 0.8.10 in the workflow, Dockerfile, and Makefile. Additionally, nightly test COMPOSE targets are updated to newer RHEL release versions (9.6.0 → 9.8.0 and 10 → 10.2). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
=======================================
Coverage 35.50% 35.50%
=======================================
Files 7 7
Lines 1011 1011
=======================================
Hits 359 359
Misses 652 652
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Dockerfile.daily-tests (1)
5-5: Centralize the upstream image version to avoid future drift.
RELEASE_UPSTREAMat Line 5 is manually synchronized withMakefile(Line 10) and workflow tag (Line 22). Consider using one source of truth (e.g., CI env var/build arg) to prevent mismatch in future bumps.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile.daily-tests` at line 5, The Dockerfile currently hardcodes RELEASE_UPSTREAM which diverges from the Makefile and workflow tag; replace the literal with a build-time ARG or environment variable so a single source of truth is used: add ARG RELEASE_UPSTREAM (or use an existing CI env var) in the Dockerfile and reference that ARG where RELEASE_UPSTREAM is used, then update the Makefile target and CI workflow to pass the same build-arg/env (e.g., docker build --build-arg RELEASE_UPSTREAM=$RELEASE_UPSTREAM or export RELEASE_UPSTREAM in CI) so the Dockerfile, Makefile, and workflow consume the same variable rather than duplicating the version string.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Dockerfile.daily-tests`:
- Line 5: The Dockerfile currently hardcodes RELEASE_UPSTREAM which diverges
from the Makefile and workflow tag; replace the literal with a build-time ARG or
environment variable so a single source of truth is used: add ARG
RELEASE_UPSTREAM (or use an existing CI env var) in the Dockerfile and reference
that ARG where RELEASE_UPSTREAM is used, then update the Makefile target and CI
workflow to pass the same build-arg/env (e.g., docker build --build-arg
RELEASE_UPSTREAM=$RELEASE_UPSTREAM or export RELEASE_UPSTREAM in CI) so the
Dockerfile, Makefile, and workflow consume the same variable rather than
duplicating the version string.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f64c2b3a-4ea2-4ac7-8d2e-f58f3b67f4c9
📒 Files selected for processing (4)
.github/workflows/build-and-push.ymlDockerfile.daily-testsMakefilerun_nightly_tests.sh
Summary by CodeRabbit