Fixed #6

[59naga]

Before

getPixels('animated.gif?1430103876000',function(error,pixels){
  console.log(pixels.shape.length===3)// true
});

After

getPixels('animated.gif?1430103876000',function(error,pixels){
  console.log(pixels.shape.length===4)// true
});

Fixes #6.

[benwiley4000]

ignore

GitHub and I are not getting along today...

[benwiley4000]

This looks great to me but I'm just hesitant about the way we handle non-String url values. Would love to see it merged ASAP! 😄

Also sorry, the review looked weird the first time so I re-posted. 👀

[benwiley4000]

It's not obvious to me what url.toString() would do if it's not already a String.

I checked, and it looks like path.extname(undefined) creates an error in Node's path module (at least the current version), while it returns an empty string for node-browserify (the browserify built-in which gets included in bundles). That said, the previous line was already relying on non-standard behavior.

What about:

var ext = url ? path.extname(url.split('?')[0]) : ''

or:

var ext = typeof url === 'string' ? path.extname(url.split('?')[0]) : ''

🙂