Send Expect: 100-continue on BackbeatRoutes requests with a body#25
Open
maeldonn wants to merge 1 commit into
Open
Send Expect: 100-continue on BackbeatRoutes requests with a body#25maeldonn wants to merge 1 commit into
maeldonn wants to merge 1 commit into
Conversation
Hello maeldonn,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
ade6dfa to
e5c733b
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
e5c733b to
60ec79f
Compare
Contributor
|
finishing some stuff on another cloudserverclient pr, will recheck and try to integrate later |
0218f27 to
c1b98cb
Compare
Expose a per-command helper that wraps the AWS SDK Expect: 100-continue middleware so callers can opt commands like PutData into the handshake, letting the server reject invalid requests before the body is streamed. The threshold is configurable to skip the cost on small payloads. Issue: CLDSRVCLT-15
c1b98cb to
6730f1c
Compare
maeldonn
commented
May 27, 2026
| export function attachExpectContinueMiddleware<TCommand>( | ||
| command: TCommand & WithMiddlewareStack, | ||
| requestHandler?: RequestHandler<unknown, unknown>, | ||
| expectContinueHeader: boolean | number = true, |
Contributor
Author
There was a problem hiding this comment.
Should the default for expectContinueHeader stay true (matches AWS S3 client, fail-fast at any size), or switch to a small threshold like 1024 to skip the handshake on tiny payloads? Leaning true for consistency, but happy to switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire the AWS SDK expect-continue middleware into BackbeatRoutesClient so the server can reject invalid PutData requests before the body is streamed.
Issue: CLDSRVCLT-14