Skip to content

CLDSRV-908: CopyObject handle checksums#6176

Open
leif-scality wants to merge 6 commits into
development/9.4from
improvement/CLDSRV-908-copy-object-handle-checksums
Open

CLDSRV-908: CopyObject handle checksums#6176
leif-scality wants to merge 6 commits into
development/9.4from
improvement/CLDSRV-908-copy-object-handle-checksums

Conversation

@leif-scality
Copy link
Copy Markdown
Contributor

  • Forward a src object checksum to the dest object
  • Recompute the checksum when required (x-amz-checksum-algorithm header set, src object MPU with COMPOSITE checksum, ...)

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 27, 2026

Hello leif-scality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented May 27, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-908 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.0

Please check the Fix Version/s of CLDSRV-908, or the target
branch of this pull request.

Comment thread lib/api/objectCopy.js Dismissed
after(async () => bucketUtil.deleteMany([sourceBucketName, destBucketName]));

const { algorithms } = require(
'../../../../../lib/api/apiUtils/integrity/validateChecksums');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This require() is inside the withV4 callback / describe block. Per project conventions, require() calls should be at the top of the file, not inside describe or functions.

— Claude Code

@claude
Copy link
Copy Markdown

claude Bot commented May 27, 2026

LGTM — clean implementation of checksum propagation and recompute on CopyObject. Stream handling (jsutil.once guards, Azure per-part passthrough, error propagation) and the _shouldRecomputeChecksum decision logic are solid. One minor test style issue flagged inline.

- require() inside describe/withV4 callback in functional test — move to top of file

Review by Claude Code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

❌ Patch coverage is 73.26733% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.24%. Comparing base (538c16c) to head (5ca489a).
⚠️ Report is 7 commits behind head on development/9.4.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/objectCopy.js 70.65% 27 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/integrity/validateChecksums.js 99.08% <100.00%> (+0.03%) ⬆️
lib/api/objectCopy.js 87.27% <70.65%> (-4.23%) ⬇️
@@                 Coverage Diff                 @@
##           development/9.4    #6176      +/-   ##
===================================================
- Coverage            85.29%   85.24%   -0.06%     
===================================================
  Files                  208      208              
  Lines                13917    14009      +92     
===================================================
+ Hits                 11871    11942      +71     
- Misses                2046     2067      +21     
Flag Coverage Δ
file-ft-tests 68.87% <73.26%> (+0.05%) ⬆️
kmip-ft-tests 28.10% <22.77%> (-0.03%) ⬇️
mongo-v0-ft-tests 70.07% <73.26%> (+0.11%) ⬆️
mongo-v1-ft-tests 70.09% <73.26%> (+0.06%) ⬆️
multiple-backend 36.39% <5.94%> (-0.21%) ⬇️
sur-tests 35.29% <10.89%> (-1.08%) ⬇️
sur-tests-inflights 37.18% <10.89%> (-0.20%) ⬇️
utapi-v2-tests 34.52% <22.77%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants