CLDSRV-908: CopyObject handle checksums#6176
Conversation
leif-scality
commented
May 27, 2026
- Forward a src object checksum to the dest object
- Recompute the checksum when required (x-amz-checksum-algorithm header set, src object MPU with COMPOSITE checksum, ...)
Hello leif-scality,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
| after(async () => bucketUtil.deleteMany([sourceBucketName, destBucketName])); | ||
|
|
||
| const { algorithms } = require( | ||
| '../../../../../lib/api/apiUtils/integrity/validateChecksums'); |
There was a problem hiding this comment.
This require() is inside the withV4 callback / describe block. Per project conventions, require() calls should be at the top of the file, not inside describe or functions.
— Claude Code
|
LGTM — clean implementation of checksum propagation and recompute on CopyObject. Stream handling (jsutil.once guards, Azure per-part passthrough, error propagation) and the _shouldRecomputeChecksum decision logic are solid. One minor test style issue flagged inline. |
Codecov Report❌ Patch coverage is
Additional details and impacted files
@@ Coverage Diff @@
## development/9.4 #6176 +/- ##
===================================================
- Coverage 85.29% 85.24% -0.06%
===================================================
Files 208 208
Lines 13917 14009 +92
===================================================
+ Hits 11871 11942 +71
- Misses 2046 2067 +21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|