CLDSRV-873: return checksum in HeadObject and GetObject#6117
Draft
leif-scality wants to merge 1 commit intoimprovement/CLDSRV-872-store-checksum-in-object-metadatafrom
Conversation
leif-scality
changed the title
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| const responseHeaders = collectResponseHeaders(objMD, corsHeaders, | ||
| verCfg); | ||
|
|
||
| if (checksumMode === 'ENABLED') { |
There was a problem hiding this comment.
PR title says "return checksum in HeadObject and GetObject" but only HeadObject is implemented. lib/api/objectGet.js has no changes — it does not validate x-amz-checksum-mode or set checksum response headers. Either add GetObject support or update the title.
— Claude Code
Review by Claude Code |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes @@ Coverage Diff @@
## improvement/CLDSRV-872-store-checksum-in-object-metadata #6117 +/- ##
============================================================================================
+ Coverage 84.69% 84.72% +0.02%
============================================================================================
Files 207 207
Lines 13540 13549 +9
============================================================================================
+ Hits 11468 11479 +11
+ Misses 2072 2070 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.