Update functional tests to use cloudserverclient extended commands

[maeldonn]

Issue: CLDSRV-868

[bert-e]

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Incorrect fix version

The Fix Version/s in issue CLDSRV-868 contains:

• None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

• 9.3.6

• 9.4.0

Please check the Fix Version/s of CLDSRV-868, or the target
branch of this pull request.

[maeldonn]

Suggested change

	"@scality/cloudserverclient": "github:scality/cloudserverclient#improvement/CLDSRVCLT-10/user-metadata",
	"@scality/cloudserverclient": "^1.0.5",

[claude]

• cloudserverclient is pinned to a branch instead of a tag. Git-based deps should pin to a tag for reproducible builds.
  • Pin to a release tag once available, or pin to the specific commit hash.

Review by Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.24%. Comparing base (1ff2d99) to head (29f89da).
⚠️ Report is 36 commits behind head on development/9.3.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6103      +/-   ##
===================================================
- Coverage            84.25%   84.24%   -0.01%     
===================================================
  Files                  206      206              
  Lines                13251    13251              
===================================================
- Hits                 11164    11163       -1     
- Misses                2087     2088       +1     

Flag	Coverage Δ
file-ft-tests	67.91% <ø> (ø)
kmip-ft-tests	28.08% <ø> (ø)
mongo-v0-ft-tests	69.11% <ø> (ø)
mongo-v1-ft-tests	69.23% <ø> (-0.02%)	⬇️
multiple-backend	35.10% <ø> (ø)
sur-tests	36.46% <ø> (ø)
sur-tests-inflights	37.49% <ø> (ø)
unit	69.90% <ø> (ø)
utapi-v2-tests	34.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[DarkIsDude]

Your CI is fully broken

[claude]

LGTM

Clean refactor replacing manual middleware hacks (custom request handlers, XML parsing, header injection) with the @scality/cloudserverclient extended commands. The new dependency is properly pinned to an exact version (1.0.5) in devDependencies, the @aws-sdk/client-s3 bump is consistent with the transitive dependency from cloudserverclient, and the new test case for non-existing metadata keys is a good addition.

Review by Claude Code

[claude]

• head.js:24 — err.name === "Unknown" is a weak assertion that will match any unrecognized error, not specifically a missing-bucket-name error. Consider also asserting on the HTTP status code or another specific property.

Review by Claude Code

[DarkIsDude]

LGTM, congrats

[claude]

LGTM

Clean refactor replacing manual middleware/XML-parsing workarounds with the @scality/cloudserverclient extended commands. The .toDate() fixes for moment objects and the updated empty-bucket-name error assertions align with the AWS SDK v3 upgrade. New test case for non-existing-only metadata keys is a nice addition.

Review by Claude Code

[claude]

LGTM

Clean refactor replacing manual middleware/XML-parsing workarounds with proper @scality/cloudserverclient extended commands (ListObjectsV2ExtendedCommand, GetObjectAttributesExtendedCommand). The .toDate() additions correctly fix moment-to-Date compatibility with AWS SDK v3, and the test adjustments for empty bucket name validation reflect the updated SDK behavior (server-side 405 instead of client-side validation error). New test coverage for non-existing metadata keys is a good addition.

Review by Claude Code

[claude]

• The @scality/cloudserverclient devDep transitively requires @aws-sdk/client-s3 ^3.1009.0, forcing production SDK from ^3.931.0 to 3.1009.0. The declared version in package.json is misleading. Align to ^3.1009.0 or isolate the transitive pull.
• The empty-bucket-name test in get.js was removed, but the analogous test in head.js was updated to assert 405 status. Update get.js test similarly instead of deleting it to preserve coverage.

Review by Claude Code

[claude]

fast-xml-parser resolution uses >=5.5.6 which has no upper bound and could pull in breaking major versions. Use ^5.5.6 instead to cap at the current major.

Review by Claude Code

[claude]

• fast-xml-parser resolution uses >=5.5.6 which is unbounded and could pull in future breaking major versions. Use ^5.5.6 instead.

Review by Claude Code

[claude]

• package.json:88 — fast-xml-parser resolution pinned to exact version 5.3.8. Will not receive automatic patch-level security fixes. Consider using ^5.3.8 unless there is a specific reason to lock this version.
• tests/functional/aws-node-sdk/test/bucket/head.js:25 — Asserting err.name is Unknown is fragile for HEAD responses. Add a comment explaining why Unknown is expected.

Review by Claude Code

[claude]

• The fast-xml-parser resolution uses >=5.5.6 (open-ended range), which could pull in future breaking major versions. Use ^5.5.6 instead.
• The HEAD bucket empty-name test asserts err.name === Unknown, which is fragile.
• The @aws-sdk/client-s3 bump from ^3.908.0 to ^3.1012.0 is a large jump -- validate no regressions in middleware APIs used in production code.
• Test removals for SDK client-side validation are correct since newer SDK no longer performs these checks.

Overall the refactoring to @scality/cloudserverclient extended commands is a clean improvement.

Review by Claude Code

[claude]

• package.json: Resolutions for fast-xml-parser and @aws-sdk/xml-builder use >= which is too loose and could pull in future breaking changes. Use ^ instead.
  - tests/functional/aws-node-sdk/test/bucket/head.js: Asserting err.name === Unknown is fragile and does not verify the actual error condition.
  
  Review by Claude Code

[claude]

• package.json:23 -- The aws-sdk/client-s3 bump is a production dependency change in a PR scoped to test updates. The yarn.lock resolves two separate versions of aws-sdk/client-s3, which can cause middleware/instanceof issues. Clarify whether the production bump is intentional. Consider deduplicating.
• package.json:88 -- fast-xml-parser 5.5.6 in resolutions forces a v4-to-v5 major version upgrade for all transitive consumers. Verify no production dependency relies on fast-xml-parser v4 API.

Review by Claude Code

[maeldonn]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/9.3

• ✔️ development/9.4

The following branches will NOT be impacted:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/9.3

• ✔️ development/9.4

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2

Please check the status of the associated issue CLDSRV-868.

Goodbye maeldonn.