Detect unused Cucumber step definitions in CI

.github/workflows/end2end.yaml

@@ -404,6 +404,9 @@ jobs:
       - name: Lint ctst tests
         working-directory: tests/ctst
         run: yarn lint
+      - name: Check for unused step definitions
+        working-directory: tests/ctst
+        run: yarn unused-steps
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v4
       - name: Login to Registry

tests/ctst/common/common.ts

@@ -202,12 +202,6 @@ Given('{int} objects {string} of size {int} bytes with user metadata {string}',
         assert.ifError(result?.stderr || result?.err);
     });
 
-Given('{int} mpu objects {string} of size {int} bytes with user metadata {string}',
-    async function (this: Zenko, numberObjects: number, objectName: string, sizeBytes: number, userMD: string) {
-        const result = await addMultipleObjects.call(this, numberObjects, objectName, sizeBytes, userMD);
-        assert.ifError(result?.stderr || result?.err);
-    });
-
 Given('a tag on object {string} with key {string} and value {string}',
     async function (this: Zenko, objectName: string, tagKey: string, tagValue: string) {
         this.resetCommand();

tests/ctst/package.json

@@ -37,7 +37,8 @@
   },
   "scripts": {
     "build": "tsc --build tsconfig.json",
-    "lint": "eslint ."
+    "lint": "eslint .",
+    "unused-steps": "! cucumber-js --config cucumber.config.cjs --dry-run --format usage 2>&1 | grep UNUSED"
   },
   "resolutions": {
     "@azure/core-client": "1.10.1"

tests/ctst/steps/azureArchive.ts

@@ -482,14 +482,3 @@ When('i change azure archive location {string} container target', { timeout: 15
         await waitForZenkoToStabilize(this, true);
         await waitForDataServicesToStabilize(this);
     });
-
-Then('i can get the {string} location details', async function (this: Zenko, locationName: string) {
-    const result = await this.managementAPIRequest('GET', `/config/overlay/view/${this.parameters.InstanceID}`);
-    if ('err' in result) {
-        assert.ifError(result.err);
-    }
-    if ('data' in result) {
-        const { locations } = result.data as { locations: Record<string, unknown> };
-        assert(locations[locationName]);
-    }
-});

tests/ctst/steps/pra.ts

@@ -182,17 +182,6 @@ Given('a DR installed', { timeout: installTimeout + 2000 }, async function (this
     return;
 });
 
-Given('a DR failing to be installed', { timeout: 130000 }, async function (this: Zenko) {
-    Identity.useIdentity(IdentityEnum.ACCOUNT, Zenko.sites['source'].accountName);
-    const credentials = Identity.getCurrentCredentials();
-    await createSecret(this, 'drctl-s3-creds', {
-        accessKey: Buffer.from(credentials.accessKeyId).toString('base64'),
-        secretAccessKey: Buffer.from(credentials.secretAccessKey).toString('base64'),
-    });
-    await installPRA(this, 'http://s3.dr.zenko.local');
-    return;
-});
-
 Then('the DR sink should be in phase {string}', { timeout: 360000 }, async function (this: Zenko, state: string) {
     let targetPhase;
     switch (state) {