Fix Logic and Data Type Errors in Rock-Paper-Scissors Game #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses and resolves the issues identified in the Rock-Paper-Scissors game code, improving gameplay flow and accuracy.
Changes Made:
Corrected Data Type Mismatch: Replaced random.randint() with random.choice() for the computer's choice, ensuring direct selection of "rock," "paper," or "scissors" and preventing integer-string comparison errors.
Improved Game Logic: Modified the game loop to allow continuous play until a clear win or loss is determined, with proper handling of ties.
Added Input Validation: Ensured that user input is validated, prompting users to enter only valid choices ("rock," "paper," or "scissors") to prevent unintended behavior.
Refactored Code Structure: Enhanced readability with consistent indentation and streamlined conditions to make the game logic more intuitive and maintainable.
Outcome:
These changes result in smoother, error-free gameplay and provide users with a clearer and more reliable Rock-Paper-Scissors experience.