Skip to content

linter: false positive with constraint-missing-not-valid #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Oct 18, 2025
Merged

linter: false positive with constraint-missing-not-valid #694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions crates/squawk_linter/src/rules/constraint_missing_not_valid.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,13 @@ pub(crate) fn constraint_missing_not_valid(ctx: &mut Linter, parse: &Parse<Sourc
continue;
}
}
if let Some(ast::Constraint::PrimaryKeyConstraint(pk)) =
add_constraint.constraint()
{
if pk.using_index().is_some() {
continue;
}
}

ctx.report(Violation::for_node(
Rule::ConstraintMissingNotValid,
Expand Down Expand Up @@ -206,6 +213,15 @@ ALTER TABLE distributors VALIDATE CONSTRAINT distfk;
assert_eq!(errors.len(), 0);
}

#[test]
fn adding_using_index_ok() {
let sql = r#"
ALTER TABLE account ADD CONSTRAINT account_pk PRIMARY KEY USING INDEX account_pk_idx;
"#;
let errors = lint(sql, Rule::ConstraintMissingNotValid);
assert_eq!(errors.len(), 0);
}

#[test]
fn adding_check_constraint_err() {
let sql = r#"
Expand Down
Loading