Skip to content

linter: support table in possibly_slow_stmt #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Oct 12, 2025
Merged

linter: support table in possibly_slow_stmt #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/squawk_linter/src/analyze.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ pub fn possibly_slow_stmt(stmt: &ast::Stmt) -> bool {
| ast::Stmt::SetSessionAuth(_)
| ast::Stmt::SetTransaction(_)
| ast::Stmt::Show(_)
| ast::Stmt::Table(_)
| ast::Stmt::Unlisten(_)
| ast::Stmt::Update(_)
| ast::Stmt::Values(_) => false,
Expand Down
6 changes: 3 additions & 3 deletions crates/squawk_parser/src/grammar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11361,7 +11361,7 @@ fn move_(p: &mut Parser<'_>) -> CompletedMarker {
opt_direction(p);
let _ = p.eat(FROM_KW) || p.eat(IN_KW);
// cursor_name
name(p);
name_ref(p);
m.complete(p, MOVE)
}

Expand All @@ -11388,7 +11388,7 @@ fn fetch(p: &mut Parser<'_>) -> CompletedMarker {
opt_direction(p);
let _ = p.eat(FROM_KW) || p.eat(IN_KW);
// cursor_name
name(p);
name_ref(p);
m.complete(p, FETCH)
}

Expand Down Expand Up @@ -12272,7 +12272,7 @@ fn opt_where_current_of(p: &mut Parser<'_>) {
if p.eat(WHERE_KW) {
if p.eat(CURRENT_KW) {
p.expect(OF_KW);
ident(p);
name_ref(p);
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions crates/squawk_parser/tests/snapshots/tests__delete_ok.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,8 @@ SOURCE_FILE
WHITESPACE " "
OF_KW "of"
WHITESPACE " "
IDENT "invoice_cursor"
NAME_REF
IDENT "invoice_cursor"
SEMICOLON ";"
WHITESPACE "\n\n"
COMMENT "-- returning"
Expand Down Expand Up @@ -934,7 +935,8 @@ SOURCE_FILE
WHITESPACE " "
OF_KW "OF"
WHITESPACE " "
IDENT "c_tasks"
NAME_REF
IDENT "c_tasks"
SEMICOLON ";"
WHITESPACE "\n\n"
DELETE
Expand Down
36 changes: 18 additions & 18 deletions crates/squawk_parser/tests/snapshots/tests__fetch_ok.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -23,7 +23,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -34,7 +34,7 @@ SOURCE_FILE
WHITESPACE " "
IN_KW "in"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -43,7 +43,7 @@ SOURCE_FILE
WHITESPACE " "
PRIOR_KW "prior"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n\n"
Expand All @@ -54,7 +54,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -65,7 +65,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -76,7 +76,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -87,7 +87,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -101,7 +101,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -115,7 +115,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -127,7 +127,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -138,7 +138,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -149,7 +149,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -163,7 +163,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -176,7 +176,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -187,7 +187,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -201,7 +201,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -214,7 +214,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n\n"
36 changes: 18 additions & 18 deletions crates/squawk_parser/tests/snapshots/tests__move_ok.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -23,7 +23,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "from"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -34,7 +34,7 @@ SOURCE_FILE
WHITESPACE " "
IN_KW "in"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -43,7 +43,7 @@ SOURCE_FILE
WHITESPACE " "
PRIOR_KW "prior"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n\n"
Expand All @@ -54,7 +54,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -65,7 +65,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -76,7 +76,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -87,7 +87,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -101,7 +101,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -115,7 +115,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -127,7 +127,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -138,7 +138,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -149,7 +149,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -163,7 +163,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -176,7 +176,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -187,7 +187,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -201,7 +201,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n"
Expand All @@ -214,7 +214,7 @@ SOURCE_FILE
WHITESPACE " "
FROM_KW "FROM"
WHITESPACE " "
NAME
NAME_REF
IDENT "cursor_name"
SEMICOLON ";"
WHITESPACE "\n\n"
3 changes: 2 additions & 1 deletion crates/squawk_parser/tests/snapshots/tests__update_ok.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1120,7 +1120,8 @@ SOURCE_FILE
WHITESPACE " "
OF_KW "OF"
WHITESPACE " "
IDENT "c_films"
NAME_REF
IDENT "c_films"
SEMICOLON ";"
WHITESPACE "\n\n"
UPDATE
Expand Down
Loading
Loading