Skip to content

vscode: fix window file path issues #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 1 commit into from
Jul 23, 2025
Merged

vscode: fix window file path issues #595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions squawk-vscode/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ export default tseslint.config(
rules: {
"no-console": "error",
"quotes": ["error", "double", { "avoidEscape": true }],
"no-restricted-syntax": [
"error",
{
"selector": "MemberExpression[property.name='path']",
"message": "Use .fsPath instead of .path"
}
],
"@typescript-eslint/no-unused-vars": [
"error",
{
Expand Down
8 changes: 4 additions & 4 deletions squawk-vscode/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export async function activate(context: vscode.ExtensionContext) {
vscode.commands.registerCommand("squawk.serverVersion", () => {
try {
const serverPath = getSquawkPath(context)
const stdout = execFileSync(serverPath.path, ["--version"], {
const stdout = execFileSync(serverPath.fsPath, ["--version"], {
encoding: "utf8",
})
const version = stdout.trim()
Expand Down Expand Up @@ -252,15 +252,15 @@ async function startServer(context: vscode.ExtensionContext) {
() => false,
)
if (!hasBinary) {
const errorMsg = `Squawk binary not found at: ${squawkPath.path}`
const errorMsg = `Squawk binary not found at: ${squawkPath.fsPath}`
log.error(`ERROR: ${errorMsg}`)
vscode.window.showErrorMessage(errorMsg)
return
}
log.info(`Found Squawk binary at: ${squawkPath.path}`)
log.info(`Found Squawk binary at: ${squawkPath.fsPath}`)

const serverExecutable: Executable = {
command: squawkPath.path,
command: squawkPath.fsPath,
args: ["server", "--verbose"],
}
const serverOptions: ServerOptions = serverExecutable
Expand Down
Loading