parser: pg regression suite tidying #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
fyi @psteinroe |
Contributor
awesome! fyi: I realised that not all statements in the regression suite are meant to be valid. its not strictly annotated, but most have some sort if comment above them. so maybe we should add a "ignore list" to the suite. |
Owner
Author
|
Ah yeah I saw some of those, makes the job a little trickier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we keep snapshots of the errors as well as having a test keep track of files that have errors and the error count.
We can gradually burn down the files & error counts!
Also fix a few panics that the regression suite had with select