Skip to content

Conversation

@psteinroe
Copy link
Contributor

let me know if you want this. I think the separation will be beneficial when I add the regression test suite back.

ref: https://doc.rust-lang.org/rust-by-example/testing/integration_testing.html

@netlify
Copy link

netlify bot commented May 19, 2025

👷 Deploy request for squawkhq pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d1d4c0e

@sbdchd
Copy link
Owner

sbdchd commented May 20, 2025

I think I copied what rust analyzer is doing with their parser https://github.com/rust-lang/rust-analyzer/tree/master/crates/parser

They have:

  • src/
  • test_data/

Meanwhile, ruff https://github.com/astral-sh/ruff/tree/main/crates/ruff_python_parser has:

  • src/
  • resources/
  • tests/

I like the test_data/ just being a bunch of non-rust files, but cool with moving the actually rust test files to tests/

@psteinroe
Copy link
Contributor Author

I think the biggest difference is that in integration tests, you import the crate and are limited to its public api. I prefer this distinction for tests like we have here, but I will leave the decision up to you :)

@sbdchd
Copy link
Owner

sbdchd commented May 20, 2025

@psteinroe ah that makes sense, seems fine to move them to test/!

@psteinroe
Copy link
Contributor Author

@psteinroe ah that makes sense, seems fine to move them to test/!

can we merge this then? :)

@sbdchd sbdchd added the automerge automerge with kodiak label May 22, 2025
@sbdchd
Copy link
Owner

sbdchd commented May 22, 2025

Oops sorry!

@kodiakhq kodiakhq bot merged commit 948d73f into sbdchd:master May 22, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge automerge with kodiak

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants