Check if existing comment contains "Squawk Report" header. #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes sbdchd#476 When searching for an existing comment to overwrite, check the body of each comment to see if it includes the expected header. This should prevent Squawk from accidentally overwriting comments generated by other GHAs.
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
danxmoran
commented
May 14, 2025
| match comments.iter().find(|x| { | ||
| x.user.r#type == "Bot" | ||
| && x.user.login == bot_name | ||
| && x.body.contains(existing_comment_text_includes) |
Contributor
Author
There was a problem hiding this comment.
I thought about using starts_with here to be even more specific, but I wasn't sure how that would play with the markdown generation
Owner
There was a problem hiding this comment.
ah is the issue that there's one bot account setup and multiple apps, other than squawk, use it?
Edit: read your issue, makes sense!
Owner
There was a problem hiding this comment.
can we add a comment explaining the reasoning? otherwise looks good!
sbdchd
requested changes
May 14, 2025
Owner
sbdchd
left a comment
sbdchd
left a comment
There was a problem hiding this comment.
Looks good, one minor comment about adding a comment!
| match comments.iter().find(|x| { | ||
| x.user.r#type == "Bot" | ||
| && x.user.login == bot_name | ||
| && x.body.contains(existing_comment_text_includes) |
Owner
There was a problem hiding this comment.
can we add a comment explaining the reasoning? otherwise looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476
When searching for an existing comment to overwrite, check the body of each comment to see if it includes the expected header. This should prevent Squawk from accidentally overwriting comments generated by other GHAs.