Skip to content

parser: fix parsing nested compound select with parens #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 2 commits into from
May 12, 2025
Merged

parser: fix parsing nested compound select with parens #464

kodiakhq merged 2 commits into from
May 12, 2025

Conversation

@chdsbd
Copy link
Collaborator

@chdsbd chdsbd commented May 12, 2025 •
edited by sbdchd
Loading

we were handling

SELECT (
  (SELECT c FROM t)
  UNION
  SELECT c FROM u
) LIMIT 1;

but not

SELECT (
  (SELECT c FROM t)
  UNION
  (SELECT c FROM u)
) LIMIT 1;

related: #463

chdsbd and others added 2 commits May 12, 2025 09:25
@chdsbd
add test case for panic
08afad2
@sbdchd
fix parsing nested compound select with parens
fc80f22 
we were handling

```sql
SELECT (
  (SELECT c FROM t)
  UNION
  SELECT c FROM u
) LIMIT 1;
```

but not

```sql
SELECT (
  (SELECT c FROM t)
  UNION
  (SELECT c FROM u)
) LIMIT 1;
```
@sbdchd sbdchd added the automerge automerge with kodiak label May 12, 2025
@sbdchd sbdchd changed the title add test case for panic parser: add test case for panic May 12, 2025
@sbdchd sbdchd changed the title parser: add test case for panic parser: fix parsing nested compound select with parens May 12, 2025
@sbdchd sbdchd marked this pull request as ready for review May 12, 2025 13:54
@kodiakhq kodiakhq bot merged commit 576ae9c into master May 12, 2025
27 checks passed
@kodiakhq kodiakhq bot deleted the compound-select branch May 12, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

automerge automerge with kodiak

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chdsbd @sbdchd