Skip to content

v2: add linter #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 7 commits into from
May 3, 2025
Merged

v2: add linter #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62a6784
v2: add linter
sbdchd May 3, 2025
be79eeb
fix
sbdchd May 3, 2025
e774cff
fix
sbdchd May 3, 2025
e3f5dc5
fmt
sbdchd May 3, 2025
a6d7149
rename
sbdchd May 3, 2025
eb50d96
fix
sbdchd May 3, 2025
b635628
fix
sbdchd May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 116 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,16 @@ camino = "1.1.9"
pg_query = "6.1.0"
rowan = "0.15.15"
smol_str = "0.3.2"
enum-iterator = "2.1.0"
line-index = "0.1.2"

# local
squawk-parser = { version = "0.0.0", path = "./crates/parser" }
squawk-linter = { version = "0.0.0", path = "./crates/linter" }
squawk-github = { version = "0.0.0", path = "./crates/github" }
squawk_lexer = { version = "0.0.0", path = "./crates/squawk_lexer" }
squawk_parser = { version = "0.0.0", path = "./crates/squawk_parser" }
squawk_syntax = { version = "0.0.0", path = "./crates/squawk_syntax" }

[workspace.lints.clippy]
collapsible_else_if = "allow"
Expand Down
21 changes: 21 additions & 0 deletions crates/squawk_linter/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[package]
name = "squawk_linter"
version = "0.0.0"
edition.workspace = true
rust-version.workspace = true
authors.workspace = true
license.workspace = true

[dependencies]
squawk_syntax.workspace = true

rowan.workspace = true
serde.workspace = true
lazy_static.workspace = true
insta.workspace = true
enum-iterator.workspace = true
line-index.workspace = true


[lints]
workspace = true
31 changes: 31 additions & 0 deletions crates/squawk_linter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# linter

## rules

| name | done? |
| -------------------------------------------- | ----- |
| adding_field_with_default | y |
| adding_foreign_key_constraint | y |
| adding_not_null_field | y |
| adding_primary_key_constraint | y |
| adding_required_field | y |
| ban_char_field | y |
| ban_concurrent_index_creation_in_transaction | y |
| ban_drop_column | y |
| ban_drop_database | y |
| ban_drop_not_null | y |
| ban_drop_table | y |
| changing_column_type | y |
| constraint_missing_not_valid | y |
| disallow_unique_constraint | y |
| prefer_big_int | y |
| prefer_bigint_over_int | y |
| prefer_bigint_over_smallint | y |
| prefer_identity | y |
| prefer_robust_stmts | y |
| prefer_text_field | y |
| prefer_timestamptz | y |
| renaming_column | y |
| renaming_table | y |
| require_concurrent_index_creation | y |
| require_concurrent_index_deletion | y |
Loading
Loading