feat(github): Arg to make the github PR comment cleaner with zero violations.#1160
Open
joshzcold wants to merge 3 commits into
Open
feat(github): Arg to make the github PR comment cleaner with zero violations.#1160joshzcold wants to merge 3 commits into
joshzcold wants to merge 3 commits into
Conversation
- When enabled with zero violations the resulting comment will just be that `squawk` found no issues in the github report without showing files and paths
👷 Deploy request for squawkhq pending review.Visit the deploys page to approve it
|
joshzcold
changed the title
Owner
|
Looks good! I think this behavior seems better all around, thoughts on not making it config option and instead making it the default? |
Owner
|
another option is to stuff the sql in a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When enabled this should just post a report that looks like this
Without this we are getting lots of extra comments about sqlfiles that do not report an issue which fills up space in the PR.
This PR could also be adjusted to not have a new argument and just have this behavior by default if desired.
Thank you.