update to 2024 edition

Cargo.toml

@@ -1,13 +1,13 @@
 [workspace.package]
-edition = "2021"
+edition = "2024"
 authors = ["saying121 <saying121@outlook.com>"]
 homepage = "https://github.com/saying121/lcode"
-rust-version = "1.80.1"
+rust-version = "1.85"
 repository = "https://github.com/saying121/lcode"
 
 [workspace]
 members = ["crates/*"]
-resolver = "2"
+resolver = "3"
 exclude = [".github", "sample/"]
 
 [profile.release]

crates/key_parse/Cargo.toml

@@ -7,7 +7,7 @@ edition = { workspace = true }
 authors = { workspace = true }
 homepage = { workspace = true }
 repository = { workspace = true }
-rust-version = "1.77"
+rust-version = { workspace = true }
 keywords = ["vim", "keymap"]
 categories = ["config"]
 readme = "./README.md"

crates/key_parse/src/key_parser.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::string_slice)]
+#![allow(clippy::string_slice, reason = "todo: make it more grace")]
 
 use crossterm::event::KeyCode;
 use miette::bail;

crates/lcode-config/src/config/read_config.rs

@@ -1,10 +1,10 @@
-use std::fs::{self, write, OpenOptions};
+use std::fs::{self, OpenOptions, write};
 
 use miette::{Context, IntoDiagnostic, Result};
 
-use super::{global::*, user_nested::Suffix, LcodeConfig};
+use super::{LcodeConfig, global::*, user_nested::Suffix};
 use crate::{
-    config::{user_nested::Urls, Config},
+    config::{Config, user_nested::Urls},
     keymap::TuiKeyMap,
 };
 

crates/lcode-config/src/config/user_serializes.rs

@@ -15,7 +15,7 @@ where
     };
     Ok(res)
 }
-#[expect(clippy::trivially_copy_pass_by_ref)]
+#[expect(clippy::trivially_copy_pass_by_ref, reason = "follow signature")]
 pub fn serialize<S>(v: &Suffix, serializer: S) -> Result<S::Ok, S::Error>
 where
     S: Serializer,

crates/lcode-config/src/theme/mod.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::module_inception)]
+#![allow(clippy::module_inception, reason = "that's ok")]
 use self::theme::{Edit, Info, Select, Tab, TopicTags};
 
 pub(crate) mod theme;

crates/lcode-config/tests/serde_config_work.rs

@@ -1,5 +1,5 @@
 use lcode_config::{
-    config::{user_nested::Suffix, LcodeConfig},
+    config::{LcodeConfig, user_nested::Suffix},
     global::G_USER_CONFIG,
 };
 use miette::Result;

crates/lcode/src/app/dispatch/handle_key.rs

@@ -2,9 +2,9 @@ use crossterm::event::{Event as CrossEvent, KeyCode, KeyEvent, KeyModifiers};
 use lcode_config::{global::G_USER_CONFIG, keymap::*};
 use miette::Result;
 
-use crate::app::{inner::App, Tab2Panel, TuiIndex, TuiMode};
+use crate::app::{Tab2Panel, TuiIndex, TuiMode, inner::App};
 
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     pub async fn handle_key(&mut self, keyevent: KeyEvent) {
         let temp = if matches!(self.tab_index, TuiIndex::Select)
             && matches!(self.select.inputline.mode, TuiMode::Insert)

crates/lcode/src/app/edit/cmds/button.rs

@@ -31,7 +31,7 @@ impl ButState {
 }
 
 impl ButState {
-    #[expect(dead_code)]
+    #[expect(dead_code, reason = "util fn")]
     pub fn open(&mut self) {
         self.show = true;
     }

crates/lcode/src/app/edit/cmds/codeblock.rs

@@ -11,7 +11,7 @@ pub struct CodeBlock<'block> {
     pub mode: TuiMode,
 }
 
-impl<'block> CodeBlock<'block> {
+impl CodeBlock<'_> {
     pub fn quit_edit_tui(&mut self) -> bool {
         self.mode = TuiMode::OutEdit;
         true

crates/lcode/src/app/edit/mod.rs

@@ -16,7 +16,7 @@ pub struct EditCode<'tab1> {
     pub test: test::TestState,
 }
 
-impl<'tab1> EditCode<'tab1> {
+impl EditCode<'_> {
     pub fn normal_map(&mut self, event: CrossEvent) -> bool {
         self.code_block.normal_map(event)
     }
@@ -42,7 +42,7 @@ impl<'tab1> EditCode<'tab1> {
 }
 
 // Show only one pop view every time.
-impl<'tab1> EditCode<'tab1> {
+impl EditCode<'_> {
     pub fn toggle_menu(&mut self) -> bool {
         self.button.toggle();
         self.test.close();
@@ -63,7 +63,7 @@ impl<'tab1> EditCode<'tab1> {
     }
 }
 
-impl<'tab1> EditCode<'tab1> {
+impl EditCode<'_> {
     pub fn close_pop(&mut self) -> bool {
         if self.test.show {
             self.test.close();
@@ -148,7 +148,7 @@ impl<'tab1> EditCode<'tab1> {
         true
     }
 
-    #[allow(non_snake_case)]
+    #[expect(non_snake_case, reason = "semantic")]
     pub fn vertical_scroll_G(&mut self) -> bool {
         if self.submit.show {
             self.submit.last();

crates/lcode/src/app/impl_app/edit_qs.rs

@@ -1,12 +1,12 @@
 use leetcode_api::{
     glob_leetcode,
-    leetcode::{question::qs_detail::Question, resps::run_res::*, IdSlug},
+    leetcode::{IdSlug, question::qs_detail::Question, resps::run_res::*},
 };
 use tracing::error;
 
 use crate::{app::inner::App, mytui::myevent::UserEvent};
 
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     pub fn get_qs_detail(&self, idslug: IdSlug, force: bool) {
         let eve_tx = self.events.tx.clone();
         tokio::spawn(async move {

crates/lcode/src/app/impl_app/get_index.rs

@@ -14,7 +14,7 @@ use crate::{
     mytui::myevent::UserEvent,
 };
 
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     pub fn sync_index(&mut self) -> bool {
         if self.select.sync_bar.show {
             return false;

crates/lcode/src/app/impl_app/get_info.rs

@@ -9,12 +9,12 @@ use leetcode_api::{
 use miette::IntoDiagnostic;
 use notify_rust::Notification;
 use ratatui::prelude::*;
-use ratatui_image::{picker::Picker, protocol::StatefulProtocol, thread::ThreadProtocol, Resize};
+use ratatui_image::{Resize, picker::Picker, protocol::StatefulProtocol, thread::ThreadProtocol};
 use tokio::join;
 
 use crate::{app::inner::App, mytui::myevent::UserEvent};
 
-impl<'app> App<'app> {
+impl App<'_> {
     /// get use info
     /// If haven't checked in, check in it.
     pub fn user_info_and_checkin(&self) {
@@ -138,11 +138,13 @@ impl<'app> App<'app> {
 
             // Resize and encode in background thread.
             let tx_main_render = self.events.tx.clone();
-            thread::spawn(move || loop {
-                if let Ok((mut protocol, resize, area)) = rec_worker.recv() {
-                    protocol.resize_encode(&resize, None, area);
-                    if let Err(e) = tx_main_render.send(UserEvent::RedrawImg(protocol)) {
-                        tracing::error!("{e}");
+            thread::spawn(move || {
+                loop {
+                    if let Ok((mut protocol, resize, area)) = rec_worker.recv() {
+                        protocol.resize_encode(&resize, None, area);
+                        if let Err(e) = tx_main_render.send(UserEvent::RedrawImg(protocol)) {
+                            tracing::error!("{e}");
+                        }
                     }
                 }
             });

crates/lcode/src/app/impl_app/impl_tui.rs

@@ -3,7 +3,7 @@ use crate::{
     mytui::{myevent::EventsHandler, term::Term},
 };
 
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     /// send info for render tui
     pub fn render(&self) {
         self.events.render();

crates/lcode/src/app/info/mod.rs

@@ -21,7 +21,7 @@ pub struct Info<'tab3> {
 }
 
 // keymaps
-impl<'tab3> Info<'tab3> {
+impl Info<'_> {
     pub fn new() -> Self {
         let mut pat = Vec::with_capacity(G_USER_CONFIG.keymap.map_set.len() + 1);
         pat.push(ListItem::new(

crates/lcode/src/app/inner.rs

@@ -1,6 +1,6 @@
 use leetcode_api::{
     dao::{query::Query, save_info::FileInfo},
-    leetcode::{question::qs_detail::Question, IdSlug},
+    leetcode::{IdSlug, question::qs_detail::Question},
 };
 use miette::{IntoDiagnostic, Result};
 use ratatui_image::thread::ThreadProtocol;
@@ -10,7 +10,7 @@ use tokio::{
 };
 use tui_textarea::TextArea;
 
-use super::{dispatch::next_key, edit::EditCode, info, select, topic, TuiIndex};
+use super::{TuiIndex, dispatch::next_key, edit::EditCode, info, select, topic};
 use crate::{
     editor::{CodeTestFile, Editor},
     glob_leetcode,
@@ -40,7 +40,7 @@ pub struct App<'app> {
     pub events: EventsHandler,
 }
 
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     pub fn add_test_case(&mut self) -> bool {
         let id = self
             .edit
@@ -69,7 +69,7 @@ impl<'app_lf> App<'app_lf> {
         true
     }
 }
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     /// edit cursor qs with outer editor, for select tab
     pub async fn select_edit_cur_qs(&mut self) -> Result<()> {
         let id = self.select.current_qs();
@@ -114,7 +114,7 @@ impl<'app_lf> App<'app_lf> {
 }
 
 // tab1 edit
-impl<'app_lf> App<'app_lf> {
+impl App<'_> {
     /// from ui to file
     pub async fn save_code(&mut self) -> Result<()> {
         self.save_code = true;

crates/lcode/src/app/mod.rs

@@ -58,7 +58,7 @@ pub enum TuiMode {
     /// input panel
     Insert,
     /// input panel
-    #[expect(dead_code)]
+    #[expect(dead_code, reason = "todo use it")]
     Visual,
 
     /// not enter input

crates/lcode/src/app/select/cmds/inputline.rs

@@ -10,7 +10,7 @@ pub struct InputLine<'line> {
     pub text_line: TextArea<'line>,
 }
 
-impl<'line> InputLine<'line> {
+impl InputLine<'_> {
     pub fn handle_input(&mut self, input: Input) -> bool {
         self.text_line.input(input)
     }

crates/lcode/src/app/select/mod.rs

@@ -18,7 +18,7 @@ pub struct SelectQS<'tab0> {
     pub inputline: inputline::InputLine<'tab0>,
 }
 
-impl<'tab0> SelectQS<'tab0> {
+impl SelectQS<'_> {
     pub fn keymap_insert(&mut self, event: CrossEvent) -> bool {
         match event.into() {
             Input { key: tui_textarea::Key::Esc, .. } => self.out_edit(),

crates/lcode/src/app/topic/cmds/intputline.rs

@@ -10,7 +10,7 @@ pub struct InputLine<'line> {
     pub text_line: TextArea<'line>,
 }
 
-impl<'line> InputLine<'line> {
+impl InputLine<'_> {
     /// return if the input modified text contents or not
     pub fn handle_input(&mut self, input: Input) -> bool {
         self.text_line.input(input)

crates/lcode/src/app/topic/mod.rs

@@ -73,7 +73,7 @@ pub struct TopicTagsQS<'tab2> {
     pub ac_status: Box<[PassStat]>,
 }
 
-impl<'tab2> TopicTagsQS<'tab2> {
+impl TopicTagsQS<'_> {
     pub fn keymap_insert(&mut self, event: CrossEvent) -> bool {
         match event.into() {
             Input { key: tui_textarea::Key::Esc, .. } => self.be_out_edit(),
@@ -160,7 +160,7 @@ impl<'tab2> TopicTagsQS<'tab2> {
 }
 
 // for `difficulties`
-impl<'tab2> TopicTagsQS<'tab2> {
+impl TopicTagsQS<'_> {
     pub async fn toggle_diff(&mut self) -> bool {
         // the operate must trigger refresh
         self.difficulty.toggle_diff();
@@ -262,7 +262,7 @@ impl<'tab2> TopicTagsQS<'tab2> {
 }
 
 // all topic tags, add remove topic
-impl<'tab2> TopicTagsQS<'tab2> {
+impl TopicTagsQS<'_> {
     /// remove a topic and refresh question
     pub async fn rm_user_topic(&mut self) -> bool {
         let trigger = self.topic.rm_user_topic();
@@ -301,7 +301,7 @@ impl<'tab2> TopicTagsQS<'tab2> {
 }
 
 // filtered questions
-impl<'tab2> TopicTagsQS<'tab2> {
+impl TopicTagsQS<'_> {
     pub fn next_qs(&mut self) {
         self.question_state.next();
     }
@@ -322,7 +322,7 @@ impl<'tab2> TopicTagsQS<'tab2> {
 }
 
 // user topic tags
-impl<'tab2> TopicTagsQS<'tab2> {
+impl TopicTagsQS<'_> {
     pub fn prev_user_topic(&mut self) {
         self.topic.prev_user();
     }

crates/lcode/src/cli.rs

@@ -1,10 +1,10 @@
 use std::io;
 
 use clap::{Args, Command, CommandFactory, Parser, Subcommand};
-use clap_complete::{generate, Generator, Shell};
+use clap_complete::{Generator, Shell, generate};
 use colored::Colorize;
 use lcode_config::{
-    config::{user_nested::Suffix, LcodeConfig},
+    config::{LcodeConfig, user_nested::Suffix},
     global::G_DATABASE_PATH,
 };
 use leetcode_api::{leetcode::IdSlug, render::Render};
@@ -27,8 +27,8 @@ struct Cli {
     command: Option<Commands>,
 }
 
-fn print_completions<G: Generator>(gen: G, cmd: &mut Command) {
-    generate(gen, cmd, cmd.get_name().to_owned(), &mut io::stdout());
+fn print_completions<G: Generator>(genen: G, cmd: &mut Command) {
+    generate(genen, cmd, cmd.get_name().to_owned(), &mut io::stdout());
 }
 
 #[derive(Debug)]

crates/lcode/src/editor.rs

@@ -7,7 +7,7 @@ use leetcode_api::{
 };
 use miette::{IntoDiagnostic, Result};
 use tokio::{
-    fs::{self, create_dir_all, OpenOptions},
+    fs::{self, OpenOptions, create_dir_all},
     io::AsyncWriteExt,
 };
 use tracing::{debug, instrument};

crates/lcode/src/mytui/helper.rs

@@ -1,6 +1,6 @@
 use ratatui::{
     prelude::*,
-    widgets::{block::Title, Block, Borders},
+    widgets::{Block, Borders, block::Title},
 };
 
 /// helper function to create a bottom rect using up certain percentage of the available rect `r`

crates/lcode/src/mytui/my_widget/botton.rs

@@ -28,7 +28,7 @@ impl Default for ButtonStates {
     }
 }
 
-impl<'a> Button<'a> {
+impl Button<'_> {
     const fn colors(&self) -> (Color, Color, Color, Color) {
         let theme = self.theme;
         match self.state {
@@ -39,7 +39,7 @@ impl<'a> Button<'a> {
     }
 }
 
-impl<'a> Widget for Button<'a> {
+impl Widget for Button<'_> {
     fn render(self, area: Rect, buf: &mut Buffer) {
         let (background, text, shadow, highlight) = self.colors();
         buf.set_style(area, Style::new().bg(background).fg(text));