Skip to content

FEATURE: Add E2E test setup#45

Open
JamesAlias wants to merge 11 commits intomainfrom
feature/e2e-tests
Open

FEATURE: Add E2E test setup#45
JamesAlias wants to merge 11 commits intomainfrom
feature/e2e-tests

Conversation

@JamesAlias
Copy link
Copy Markdown
Contributor

@JamesAlias JamesAlias commented Mar 27, 2026

Add E2E test suite and named second factors

  • Feature: E2E test infrastructure: Adds a Playwright/Cucumber BDD test suite covering the four supported 2FA enforcement configurations (default, enforce-for-all, enforce-for-provider, enforce-for-role).
    Includes Dockerized system-under-test environments for Neos 8 and Neos 9, and a GitHub Actions workflow that runs the full suite on CI.
  • Feature: Named second factors: Adds an optional name field to the SecondFactor model so users can label their TOTP authenticator when registering it (e.g. "Work phone", "YubiKey app").
    -Bugfix: Neos 9 compatibility fix: Changes $this->persistenceManager->persistAll() to a null-safe call (?->) because in Neos 9 ActionControllers do not have the persistenceManager injected.
  • Chore: Configuration housekeeping: Moves the plugin's own settings block out of Settings.yaml into a dedicated Settings.2FA.yaml.
  • DX: Developer tooling: Adds a Makefile with targets for building, starting, and running the test environments and also updated Readme.

@JamesAlias JamesAlias marked this pull request as ready for review March 28, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant