Simplify kh_grow_to_fit table size check #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, early versions of clang incorrectly optimised a check to ensure that the number of buckets in a resized hash table will still fit in a khint_t, with the result that most of the function was replaced by "return -2". Fix by putting the limit value in a separate variable, so the comparison part no longer needs to do any type conversion.
daviesrob
force-pushed
the
hash-grow-fix
branch
from
c514c23 to
c37f90b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, early versions of clang incorrectly optimised a check to ensure that the number of buckets in a resized hash table will still fit in a khint_t, with the result that most of the function was replaced by "return -2". Fix by putting the limit value in a separate variable, so the comparison part no longer needs to do any type conversion.