Skip to content

Add vector PDF export for polar and heatmap charts#13

Merged
samsta merged 10 commits into
mainfrom
copilot/add-export-plots-as-pdf
May 26, 2026
Merged

Add vector PDF export for polar and heatmap charts#13
samsta merged 10 commits into
mainfrom
copilot/add-export-plots-as-pdf

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 26, 2026

  • Inspect current vector PDF export implementation and recent PR history
  • Reproduce or trace the missing legend gradient in exported PDFs
  • Make the smallest fix so SVG gradients survive PDF export
  • Run targeted validation for the export path, then full lint/test/build
  • Generate a UI screenshot for the reviewer reply
  • Run final review/security validation and reply on the PR comment

Copilot AI and others added 4 commits May 25, 2026 09:49
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/09b0dcd6-021e-4da8-b93b-7abd34639d4e

Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/09b0dcd6-021e-4da8-b93b-7abd34639d4e

Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/09b0dcd6-021e-4da8-b93b-7abd34639d4e

Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
@samsta
Copy link
Copy Markdown
Owner

samsta commented May 26, 2026

@copilot the pdfs seem to be rastered jpegs. since the plots are SVGs, can't we create pdfs with vector graphics? otherwise there's not much point in creating the pdf in the first place

Copilot AI and others added 2 commits May 26, 2026 02:52
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/3f07c599-905c-4258-abf7-addf6dc6595d

Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Agent-Logs-Url: https://github.com/samsta/KeyBpmMap/sessions/3f07c599-905c-4258-abf7-addf6dc6595d

Co-authored-by: samsta <3915450+samsta@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 26, 2026

@copilot the pdfs seem to be rastered jpegs. since the plots are SVGs, can't we create pdfs with vector graphics? otherwise there's not much point in creating the pdf in the first place

Fixed in 1680551. PDF export now sends the chart SVG through jsPDF/svg2pdf so the generated PDFs keep vector drawing commands instead of embedding a rasterized JPEG.

Copilot AI changed the title Add PDF export for polar and heatmap charts Add vector PDF export for polar and heatmap charts May 26, 2026
Copilot finished work on behalf of samsta May 26, 2026 02:54
Copilot AI requested a review from samsta May 26, 2026 02:54
@samsta
Copy link
Copy Markdown
Owner

samsta commented May 26, 2026

@copilot the legend doesn't show the gradient scale, it's just one solid color, see attached
keybpmmap-polar.pdf

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 26, 2026

@copilot the legend doesn't show the gradient scale, it's just one solid color, see attached
keybpmmap-polar.pdf

Fixed in 39af9a6. The legend scale now renders as a strip of narrow vector-filled rectangles instead of relying on an SVG gradient, so the exported PDF keeps the full color ramp.

Legend scale screenshot

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/search/issues
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of samsta May 26, 2026 09:11
@samsta samsta marked this pull request as ready for review May 26, 2026 09:35
@samsta samsta merged commit 847eae2 into main May 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants