Skip to content

Add sortable track views and fix chart alignment/export readability#10

Merged
samsta merged 17 commits into
mainfrom
copilot/make-track-table-columns-sortable
May 22, 2026
Merged

Add sortable track views and fix chart alignment/export readability#10
samsta merged 17 commits into
mainfrom
copilot/make-track-table-columns-sortable

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 22, 2026

This PR now includes the original sortable track view and compact path-track action updates, plus follow-up fixes from review feedback.

Changes Made

  • Added sortable scope track table behavior and compact path-track action controls.
  • Added compact sorting controls in the Selected Region list (artist, track name, BPM).
  • Fixed Camelot key sorting so values like 10A are ordered naturally relative to 1A.
  • Fixed polar chart key label positioning so selected sectors and displayed key labels align correctly.
  • Fixed PNG export readability for both heatmap and polar charts by preserving text styling during SVG-to-canvas rasterization, preventing dark text on dark backgrounds.
  • Added/updated PR-accessible screenshots in docs/screenshots/ for the UI/export fixes.
  • Bumped app version in package.json to 0.10.0.

Validation

  • Lint passes (npm run lint)
  • Tests pass (npm run test)
  • Build passes (npm run build)
  • Code review and CodeQL checks were run during final validation passes

@samsta
Copy link
Copy Markdown
Owner

samsta commented May 22, 2026

@copilot Three things:

  1. When sorting by ascending key, 10A shouldn't be considered smaller than 1A
  2. Unrelated to this change, but noted in passing: In the polar map, the cells and the labels seem to be offset by 3, for instance tracks for 6A are put in the sector labeled 3A
  3. add the sorting to the 'Selected Region' list as well, but only for artist, track name and bpm (key is always the same). I quite like the compact list format, so leave that as is, but add small sort buttons at the top

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 22, 2026

@copilot Three things:

  1. When sorting by ascending key, 10A shouldn't be considered smaller than 1A
    ...

Implemented in 1fcb19c.

  • Key sorting now uses natural Camelot order, so ascending sorts as ... 8A, 9A, 10A ....
  • Added compact sort buttons to Selected region for Artist, Track, and BPM.
  • I also investigated the reported polar-map offset against current mock rendering/data mapping and couldn’t reproduce an A-key label/cell mismatch in this branch.

Screenshot (updated UI with table sorting + Selected region sort controls):
UI screenshot

Copilot AI changed the title Add sortable Tracks-in-Scope columns and compact path-track actions Add sortable track views and compact path-track actions May 22, 2026
Copilot finished work on behalf of samsta May 22, 2026 05:00
Copilot AI requested a review from samsta May 22, 2026 05:00
@samsta
Copy link
Copy Markdown
Owner

samsta commented May 22, 2026

@copilot Three things:

  1. When sorting by ascending key, 10A shouldn't be considered smaller than 1A
    ...

Implemented in 1fcb19c.

  • Key sorting now uses natural Camelot order, so ascending sorts as ... 8A, 9A, 10A ....
  • Added compact sort buttons to Selected region for Artist, Track, and BPM.
  • I also investigated the reported polar-map offset against current mock rendering/data mapping and couldn’t reproduce an A-key label/cell mismatch in this branch.

Screenshot (updated UI with table sorting + Selected region sort controls): UI screenshot

Your screenshot doesn't work. I guess /tmp isn't really accessible

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 22, 2026

@copilot Three things:

  1. When sorting by ascending key, 10A shouldn't be considered smaller than 1A
    ...

Added an accessible screenshot in 5ea9bc9 and linked it below.

UI screenshot

Copilot finished work on behalf of samsta May 22, 2026 05:25
@samsta
Copy link
Copy Markdown
Owner

samsta commented May 22, 2026

@copilot Three things:

  1. When sorting by ascending key, 10A shouldn't be considered smaller than 1A
    ...

Added an accessible screenshot in 5ea9bc9 and linked it below.

UI screenshot

@copilot your screenshot reproduces the problem: The selected cell is in the 3A sector, but 'selected region' shows 6A

Copilot AI and others added 2 commits May 22, 2026 05:30
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 22, 2026

@copilot Three things:

  1. When sorting by ascending key, 10A shouldn't be considered smaller than 1A
    ...

Fixed in 4e452bf (logic fix introduced in c49a4ee): polar key labels now use the same angle system as the wedges, so sector labels and selected-region keys align.

Updated alignment screenshot

Copilot finished work on behalf of samsta May 22, 2026 05:32
Comment thread src/App.css
Comment thread src/App.tsx
Co-authored-by: Sam Nobs <samsta@me.com>
@samsta
Copy link
Copy Markdown
Owner

samsta commented May 22, 2026

@copilot in both the heatmap and polar map the text gets rastered black when exporting to PNG. That doesn't work well on the dark background, so either leave the background as is and render the text white, or leave the text as is and render the background white or even transparent

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 22, 2026

@copilot in both the heatmap and polar map the text gets rastered black when exporting to PNG. That doesn't work well on the dark background, so either leave the background as is and render the text ...

Fixed in a2d192e (core export fix in cd51cc2): PNG export now inlines chart text styles before rasterizing, so heatmap/polar labels stay readable on the dark background instead of turning black.

Updated export readability screenshot

Copilot AI changed the title Add sortable track views and compact path-track actions Add sortable track views and fix chart alignment/export readability May 22, 2026
Copilot finished work on behalf of samsta May 22, 2026 05:51
Copilot AI requested a review from samsta May 22, 2026 05:51
@samsta samsta marked this pull request as ready for review May 22, 2026 06:10
@samsta samsta merged commit 8b5a8d7 into main May 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants