Remove Abandoned Laminas Packages and Suggest Alternatives#105
Draft
nynka wants to merge 8 commits intosamsonasik:masterfrom
Draft
Remove Abandoned Laminas Packages and Suggest Alternatives#105nynka wants to merge 8 commits intosamsonasik:masterfrom
nynka wants to merge 8 commits intosamsonasik:masterfrom
Conversation
…st monolog and symfony/mailer as replacements. .
… support for PSR Loggers
Author
|
@samsonasik It seems logical to allow the user to choose their preferred logger implementation and then utilize the writers/handlers for notifications specific to that package? |
Owner
|
If that cause extra step, eg: require symfony/* lib, that probably not preferable, except we add option in command line to choose which lib to use, like mezzio-skeleton https://user-images.githubusercontent.com/1011217/90332191-55d32200-dfbb-11ea-80c0-27a07ef5691a.png |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the abandoned Laminas packages (
laminas-db,laminas-mail,laminas-log) from the project and suggests replacing them with other alternatives such asmonolog/monologandsymfony/mailer. Users of the package can select any logger implementation based onpsr/logand use Monolog handlers to get email functionality based on Symfony Mailer instead of relying on the Laminas packages.Changes:
Remove Laminas Packages:
laminas-db,laminas-mail, andlaminas-logfromcomposer.json.Update Configuration:
monolog/monologandsymfony/mailer.Instructions for Users:
psr/logand use Monolog handlers for email functionality.Detailed Changes:
composer.json:{ "require": { "php": "~8.2.0 || ~8.3.0 || ~8.4.0", "laminas/laminas-diactoros": "^2.26 || ^3.5.0", "psr/log": "^1.1 || ^2.0", }, "require-dev": { "doctrine/doctrine-orm-module": "^4.2.1 || ^5.3 || ^6.0", "laminas/laminas-coding-standard": "^3.0", "laminas/laminas-servicemanager": "^3.23 || ^4.0", "monolog/monolog": "^3.9", "symfony/mailer": "^7.2" }, "suggest": { "monolog/monolog": "Sends your logs to files, sockets, inboxes, databases and various web services", "symfony/mailer": "Symfony's Mailer & Mime components form a powerful system for creating and sending emails" }, }php/ErrorHeroModule/config/module.config.php:Instructions for Users:
psr/log.Testing:
Note:
composer.jsonand configuration files accordingly.Closing:
This PR aims to modernize the package by removing dependencies on abandoned Laminas packages and providing more flexible and widely-used alternatives and support the latest versions of PHP. It also reduces the complexity of the package itself.