chore: update ids#1692
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the client-side default client order ID prefixes used by BaseClient and aligns the ID-related tests (and CI) with the new prefixes.
Changes:
- Updated
BaseClientorder ID prefixes for spot and contract order IDs. - Updated
tests/test_ids.pyassertions to match the new prefixes. - Tweaked tooling/CI: excluded
generate_llms_txt.pyfrom Ruff and added a dedicated workflow step to run the ID tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/test_ids.py |
Updates expected spot/contract client order ID prefixes in tests. |
pyproject.toml |
Adds a Ruff exclude entry for generate_llms_txt.py. |
binance/base_client.py |
Updates SPOT_ORDER_PREFIX and CONTRACT_ORDER_PREFIX constants. |
.github/workflows/python-app.yml |
Adds an explicit CI step to run tests/test_ids.py. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.