Use XDG_DATA_DIRS to find graphical sessions #119
Conversation
samcday
added
the
ci-ok
hustlerone
force-pushed
the
main
branch
2 times, most recently
from
32fa44d to
1ef7f26
Compare
This comment has been minimized.
This comment has been minimized.
hustlerone
force-pushed
the
main
branch
2 times, most recently
from
31b6169 to
fc0da83
Compare
|
The CI build recorded and generated some videos Demo video (shown on README and release notes)
accent-colours
emergency-calls
first-run
simple-flow
trivial-flow
|
|
Hey @hustlerone thanks for this contribution. Sorry it took so long for me to get back to you. Gonna run a little experiment here, hope that's alright. @codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review: please expand on #119 (comment) with a link to Rust |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
hustlerone
force-pushed
the
main
branch
2 times, most recently
from
84cf2dc to
0beb5c9
Compare
|
once everything's satisfied i'll squash into one single commit to be merged |
hustlerone
force-pushed
the
main
branch
4 times, most recently
from
4b7a298 to
0539754
Compare
|
my computer is currently rebuilding 60gb of code sorry |
|
i'll test this later on my machine |
3 participants
NixOS is non FHS compliant. Phrog will not be able to find graphical sessions there without this.
This patch makes it so Phrog reads off of XDG_DATA_DIRS first. In case the envvar is unavailable, it'll fall back to well-known FHS compliant directory.