This repository was archived by the owner on Mar 18, 2024. It is now read-only.
Conversation
dockerclient.go
Outdated
| // ListVolumes, {Remove,Create}Volume, ListNetworks, | ||
| // {Inspect,Create,Connect,Disconnect,Remove}Network (v1.21) | ||
| APIVersion = "v1.15" | ||
| APIVersion = "v1.20" |
Contributor
There was a problem hiding this comment.
do you HAVE to bump the api ? It will have some side effects (swarm not being able to talk to engine with version < 1.20)
Collaborator
Author
There was a problem hiding this comment.
Ya unfortunately I don't think copy to container functionality was added then. Although I think we still send the request so perhaps I can just leave it 1.15 for now.
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
ehazlett
force-pushed
the
copy-container
branch
from
5567f7d to
7bf9e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for copying archives to a container.