Skip to content

aptkey is deprecated and fails in Debian Trixie#244

Open
sir-ragna wants to merge 1 commit into
saltstack-formulas:masterfrom
sir-ragna:master
Open

aptkey is deprecated and fails in Debian Trixie#244
sir-ragna wants to merge 1 commit into
saltstack-formulas:masterfrom
sir-ragna:master

Conversation

@sir-ragna
Copy link
Copy Markdown

@sir-ragna sir-ragna commented May 27, 2026

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Fixes Debian Trixie support. Remains backwards compatibility with Debian Bullseye.

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Add the signed-by gpg key attribute and disable (deprecated) aptkey.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Before:

       ----------
                 ID: php_ppa_fpm
           Function: pkgrepo.managed
               Name: deb https://packages.sury.org/php/ trixie main
             Result: False
            Comment: Failed to configure repo 'deb https://packages.sury.org/php/ trixie main': missing 'signedby' option when apt-key is missing
            Started: 15:55:21.380279
           Duration: 906.368 ms
            Changes:   
       ----------
                 ID: php_install_fpm
           Function: pkg.installed
               Name: fpm
             Result: False
            Comment: One or more requisite failed: php.fpm.install.php_ppa_fpm
            Started: 15:55:22.287931
           Duration: 0.004 ms
            Changes:  

After:

       ----------
                 ID: php_ppa_fpm
           Function: pkgrepo.managed
               Name: deb [signed-by=/etc/apt/keyrings/ondrej-php.gpg] https://packages.sury.org/php/ trixie main
             Result: True
            Comment: Configured package repo 'deb [signed-by=/etc/apt/keyrings/ondrej-php.gpg] https://packages.sury.org/php/ trixie main'
            Started: 17:03:59.287801
           Duration: 2598.181 ms
            Changes:   
              ----------
              repo:
                  deb [signed-by=/etc/apt/keyrings/ondrej-php.gpg] https://packages.sury.org/php/ trixie main
       ----------
                 ID: php_install_fpm
           Function: pkg.installed
               Name: fpm
             Result: True
            Comment: The following packages were installed/updated: php8.1-fpm
            Started: 17:04:01.888579
           Duration: 13929.164 ms
            Changes:   
              ----------
              libargon2-1:
                  ----------
                  new:
                      0~20190702+dfsg-4+b2
                  old:
              php-common:
                  ----------
                  new:
                      2:101~+0~20260503.72+debian13~1.gbp7da167
                  old:
              php8.1-cli:
                  ----------
                  new:
                      8.1.34-6+0~20260514.80+debian13~1.gbpd8e973
                  old:
              php8.1-common:
                  ----------
                  new:
                      8.1.34-6+0~20260514.80+debian13~1.gbpd8e973
                  old:
              php8.1-fpm:
                  ----------
                  new:
                      8.1.34-6+0~20260514.80+debian13~1.gbpd8e973
                  old:
              php8.1-opcache:
                  ----------
                  new:
                      8.1.34-6+0~20260514.80+debian13~1.gbpd8e973
                  old:
              php8.1-readline:
                  ----------
                  new:
                      8.1.34-6+0~20260514.80+debian13~1.gbpd8e973
                  old:

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@sir-ragna sir-ragna requested a review from sticky-note as a code owner May 27, 2026 15:20
aptkey is deprecated and fails in Debian Trixie.
We can safely disable this and still have compatibility with Bullseye.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant