Skip to content

feat(ini) support different settings for php.ini#210

Open
scambra wants to merge 1 commit into
saltstack-formulas:masterfrom
scambra:patch-3
Open

feat(ini) support different settings for php.ini#210
scambra wants to merge 1 commit into
saltstack-formulas:masterfrom
scambra:patch-3

Conversation

@scambra

@scambra scambra commented Feb 19, 2020

Copy link
Copy Markdown
Contributor

When php:version is a list, a dict with settings for different
versions can be added under ini key of cli and fpm:config keys

php:
  fpm:
    config:
      ini:
        settings:
          # global settings
        '5.6':
          # settings for 5.6 only
  cli:
    ini:
      settings:
        # global settings
      '5.6':
        # settings for 5.6 only

Related to #138, grandmotivator comment

@myii

myii commented Mar 11, 2020

Copy link
Copy Markdown
Contributor

@scambra Sorry for the delay, we need to get some eyes on this from those who use the formula. How about @grandmotivator? Could you try this out?

When php:version is a list, a dict with settings for different
versions can be added under ini key of cli and fpm:config keys

php:
  fpm:
    config:
      ini:
        settings:
          # global settings
        '5.6':
          # settings for 5.6 only
  cli:
    ini:
      settings:
        # global settings
      '5.6':
        # settings for 5.6 only
@myii

myii commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

@sticky-note Would you be able to review this as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants