Skip to content

Conversation

@pkleanthous-zz
Copy link
Contributor

Add support of dynamic Client - Director Configuration
Update README

@javierbertoli
Copy link
Member

Hi @pkleanthous, sorry for my delay on checking on this. My only suggestion (which is not that important if you don't agree, is just a matter of style), is that I'd rename the state and related files for consistency, like:

  • bareos/director_dynamic_config.sls to bareos/director/dynamic_clients.sls, so the state ends being bareos.director.dynamic_clients (which I like more)
  • bareos/files/bareos-dynamic-clients.jinja to bareos/files/director/dynamic_clients.jinja.

This would allow us to add, if needed, */{client,storage,database,whatever}/* without much issues, and making it easy to iterate or glob things.

What do you think? (Awesome work, btw!! 😄)

@javierbertoli
Copy link
Member

@pkleanthous, @aboe76, what do you think of my previous suggestion?, so we merge this PR?

@pkleanthous-zz
Copy link
Contributor Author

pkleanthous-zz commented Feb 13, 2018

Hi, @javierbertoli apologies for the late response. I get your notifications late in the night and the next day something else more important always comes up.

I need to have a look at this PR again, as since this PR my private branch move a lot.

@javierbertoli
Copy link
Member

@pkleanthous any news about this?

@pkleanthous-zz
Copy link
Contributor Author

@javierbertoli currently I don't work on bareos. Can we put this PR on hold?

@javierbertoli
Copy link
Member

sure thing. I don't have this setup, so testing it now is not easy for me either.

I'll keep it opened until we/someone can advance with it.

Thanks for all your help and patience. Any new PR you want/can submit will be appreciated!

@aboe76 aboe76 requested a review from javierbertoli June 7, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants