Fix: Use PHP 8.1 in CS Fixer CI workflow #523
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Docker image with explicit PHP 8.1 setup to match project's minimum requirement. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Fix #520 |
Contributor
Author
|
@Sammyjo20, Please take a look at this when you have a moment. |
Member
Member
|
All done in the latest release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The previous CI configuration used
oskarstark/php-cs-fixer-gaDocker image, which was running ona newer PHP version (likely 8.4). This caused inconsistent code style fixes when compared to
running php-cs-fixer locally on PHP 8.1 (the project's minimum requirement).
Solution
shivammathur/setup-php@v2to explicitly set PHP 8.1