Skip to content

Add conditional return type to ClientCredentialsGrant getAccessToken #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinmade wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Add conditional return type to ClientCredentialsGrant getAccessToken #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Traits/OAuth2/ClientCredentialsGrant.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ trait ClientCredentialsGrant
*
* @param array<string> $scopes
* @param callable(TRequest): (void)|null $requestModifier
*
* @return ($returnResponse is true ? \Saloon\Http\Response : \Saloon\Contracts\OAuthAuthenticator)
Copy link

@treyssatvincent treyssatvincent Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for Fully Qualified Domain Name as it's already used bellow in the signature:

Suggested change
* @return ($returnResponse is true ? \Saloon\Http\Response : \Saloon\Contracts\OAuthAuthenticator)
* @return ($returnResponse is true ? Response : OAuthAuthenticator)

*/
public function getAccessToken(array $scopes = [], string $scopeSeparator = ' ', bool $returnResponse = false, ?callable $requestModifier = null): OAuthAuthenticator|Response
{
Expand Down