Change Memory Store to static
#25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes saloonphp/saloon#392
This PR fixes a bug with the Memory Store which was causing all requests that run through it, to have their own store which was then causing rate limits to not work correctly. If you execute 50 requests, for example, then each of them creates a new
MemoryStoreinstance.The
HasRateLimitstrait caches the store per request:But when you do
return new MemoryStore;, each request instance gets a differentMemoryStoreobject, each with its own isolated $store array and because of this, they can't share the rate limit.The solution is to change
$storeto astaticproperty so all instances share the same storage. This makes the rate limit work across multiple request instances.You can see below the rate limit code I had in my connector and then a before and after of my results running the exact same test: