Fix deprecation warnings for implicit nullable parameters #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hey @Sammyjo20 is there anything else i can do to help get this merged? |
|
I just came across this as well. Thanks for the fix @RhysLees |
|
My team is running into this exact issue as well as we recently upgraded to PHP 8.4. Our Papertail logs have tons of deprecation warnings. Any help getting this merged in ASAP would be greatly appreciated. Tagging the contributors for visibility. @Sammyjo20 @edwinvdpol |
|
@Sammyjo20 Getting the same issues |
Member
|
Hey all, firstly massive apologies for dropping the ball on this one. Secondly I have merged #18 which fixes these same issues. Have a great weekend 🥳 |
Member
|
Fixed in #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr fixes Deprecation warnings for implicit nullable parameters
DEPRECATED Saloon\RateLimitPlugin\Limit::__construct(): Implicitly marking parameter $responseHandler as nullable is deprecated, the explicit nullable type must be used instead in vendor/saloonphp/rate-limit-plugin/src/Limit.php on line 72.DEPRECATED Saloon\RateLimitPlugin\Limit::exceeded(): Implicitly marking parameter $releaseInSeconds as nullable is deprecated, the explicit nullable type must be used instead in vendor/saloonphp/rate-limit-plugin/src/Limit.php on line 126.Fixes #15